[yt-dev] call for testing: Orion particle support

[Andrew Myers]

Yep! Works for me. Thanks for the fix.

-Andrew

On Wed, Feb 22, 2012 at 12:22 PM, j s oishi <jsoishi at gmail.com> wrote:

> Hi Andrew,
>
> I've updated the PR again. I think this should do it.
>
> j
>
> On Wed, Feb 22, 2012 at 12:17 PM, Andrew Myers <atmyers at berkeley.edu>
> wrote:
> > Hi Jeff,
> >
> > I think that "_readOrionParticleFile" needs to return 1 at line 180 in
> order
> > for this to work. With that change, I can confirm that it works for
> datasets
> > with "Star" and "No" particles. I actually don't have any data with
> > non-radiating sink particles, but I think Anna does.
> >
> > -Andrew
> >
> > On Wed, Feb 22, 2012 at 10:58 AM, j s oishi <jsoishi at gmail.com> wrote:
> >>
> >> Hi All Orion Users,
> >>
> >> I've updated my pull request (#99,
> >>
> >>
> https://bitbucket.org/yt_analysis/yt/pull-request/99/handle-case-of-orion-datasets-without-star
> )
> >> to fix Orion particle support for the cases of Star, Sink, and no
> >> particle files. Could some of you please test this code and see if it
> >> works? Once this is done, someone can accept the pull request.
> >>
> >> thanks,
> >>
> >> J.S.
> >> _______________________________________________
> >> yt-dev mailing list
> >> yt-dev at lists.spacepope.org
> >> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
> >
> >
> >
> > _______________________________________________
> > yt-dev mailing list
> > yt-dev at lists.spacepope.org
> > http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
> >
> _______________________________________________
> yt-dev mailing list
> yt-dev at lists.spacepope.org
> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.spacepope.org/pipermail/yt-dev-spacepope.org/attachments/20120222/d2f270b5/attachment.html>