Yep! Works for me. Thanks for the fix.<br><br>-Andrew<br><br><div class="gmail_quote">On Wed, Feb 22, 2012 at 12:22 PM, j s oishi <span dir="ltr"><<a href="mailto:jsoishi@gmail.com">jsoishi@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Andrew,<br>
<br>
I've updated the PR again. I think this should do it.<br>
<div class="im HOEnZb"><br>
j<br>
<br>
On Wed, Feb 22, 2012 at 12:17 PM, Andrew Myers <<a href="mailto:atmyers@berkeley.edu">atmyers@berkeley.edu</a>> wrote:<br>
</div><div class="HOEnZb"><div class="h5">> Hi Jeff,<br>
><br>
> I think that "_readOrionParticleFile" needs to return 1 at line 180 in order<br>
> for this to work. With that change, I can confirm that it works for datasets<br>
> with "Star" and "No" particles. I actually don't have any data with<br>
> non-radiating sink particles, but I think Anna does.<br>
><br>
> -Andrew<br>
><br>
> On Wed, Feb 22, 2012 at 10:58 AM, j s oishi <<a href="mailto:jsoishi@gmail.com">jsoishi@gmail.com</a>> wrote:<br>
>><br>
>> Hi All Orion Users,<br>
>><br>
>> I've updated my pull request (#99,<br>
>><br>
>> <a href="https://bitbucket.org/yt_analysis/yt/pull-request/99/handle-case-of-orion-datasets-without-star" target="_blank">https://bitbucket.org/yt_analysis/yt/pull-request/99/handle-case-of-orion-datasets-without-star</a>)<br>
>> to fix Orion particle support for the cases of Star, Sink, and no<br>
>> particle files. Could some of you please test this code and see if it<br>
>> works? Once this is done, someone can accept the pull request.<br>
>><br>
>> thanks,<br>
>><br>
>> J.S.<br>
>> _______________________________________________<br>
>> yt-dev mailing list<br>
>> <a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
>> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
><br>
><br>
><br>
> _______________________________________________<br>
> yt-dev mailing list<br>
> <a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
><br>
_______________________________________________<br>
yt-dev mailing list<br>
<a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
</div></div></blockquote></div><br>