[yt-dev] Clump finder in 3.0

Nathan Goldbaum nathan12343 at gmail.com
Sun Jun 29 16:05:14 PDT 2014


I'm not very familiar with this part of the codebase - how would I go about
doing this with the contour finder?

I'm also happy to open a trello card about this so we can come back to this
before the release.


On Sun, Jun 29, 2014 at 4:02 PM, Matthew Turk <matthewturk at gmail.com> wrote:

> Yup, looks like.  Try it with the contour finder, and we can try to
> update the clump finder appropriately.
>
> On Sun, Jun 29, 2014 at 5:48 PM, Nathan Goldbaum <nathan12343 at gmail.com>
> wrote:
> > Ah, thanks for the tip.  Guess I should have looked at the code!  I
> managed
> > to get past that error by making the following modification:
> > http://paste.yt-project.org/show/4859/
> >
> > Sadly it dies a little further on with this error:
> > http://paste.yt-project.org/show/4860/
> >
> > When I poke around with a debugger, it looks like it's trying to access
> > field data for the level-2 clump region, but the data object is empty.
> >
> >
> > On Sun, Jun 29, 2014 at 3:39 PM, Matthew Turk <matthewturk at gmail.com>
> wrote:
> >>
> >> On Sun, Jun 29, 2014 at 5:38 PM, Matthew Turk <matthewturk at gmail.com>
> >> wrote:
> >> > Hi Nathan,
> >> >
> >> > On Sun, Jun 29, 2014 at 5:31 PM, Nathan Goldbaum <
> nathan12343 at gmail.com>
> >> > wrote:
> >> >> Hi all,
> >> >>
> >> >> I'm taking a look at the plotting docs right now.
> >> >>
> >> >> One of the scripts in the callback documentation currently fails
> with a
> >> >> NotImplementedError.
> >> >
> >> > Ah, this is a side-effect of pf.h not having the .grids attribute;
> >> > simple fix.  The clump finder should work -- I completely rewrote the
> >> > it for 3.0.  There is a lingering issue with the way clump IDs are
> >> > assigned, which was the subject of a failed PR:
> >>
> >> Sorry, let me rephrase that: I completely rewrote the *contour
> >> identifier* for 3.0.  The clump finder is a layer on top of that.
> >>
> >> >
> >> >
> >> >
> https://bitbucket.org/yt_analysis/yt/pull-request/717/be-much-more-careful-about-assigning-clump
> >> >
> >> > The issue is that the clump IDs don't quite match up for some types of
> >> > data, particularly multiple root grids.  I have some scripts here to
> >> > verify it.
> >> >
> >> >>
> >> >> The somewhat scipt is here: http://paste.yt-project.org/show/4857/
> >> >>
> >> >> And the traceback is here: http://paste.yt-project.org/show/4858/
> >> >>
> >> >> I'm not sure whether anyone has looked in detail at the clump finder
> in
> >> >> 3.0.
> >> >> Does anyone know about its status?  I'm not even sure if this is an
> >> >> issue
> >> >> with the clump finder per se.
> >> >>
> >> >> -Nathan
> >> >>
> >> >> _______________________________________________
> >> >> yt-dev mailing list
> >> >> yt-dev at lists.spacepope.org
> >> >> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
> >> >>
> >> _______________________________________________
> >> yt-dev mailing list
> >> yt-dev at lists.spacepope.org
> >> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
> >
> >
> >
> > _______________________________________________
> > yt-dev mailing list
> > yt-dev at lists.spacepope.org
> > http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
> >
> _______________________________________________
> yt-dev mailing list
> yt-dev at lists.spacepope.org
> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.spacepope.org/pipermail/yt-dev-spacepope.org/attachments/20140629/a77e958e/attachment.html>


More information about the yt-dev mailing list