[yt-dev] Regression for particle deposition
Matthew Turk
matthewturk at gmail.com
Sat Jun 14 14:05:17 PDT 2014
Hi Desika,
Yup. I've issued a PR to fix it.
-Matt
On Sat, Jun 14, 2014 at 3:59 PM, Desika Narayanan
<dnarayan at haverford.edu> wrote:
> Hey Matt,
>
> Thanks - does this mean that any commit after the 2dc75b72d271 would have
> the regressed octree deposition, or that updating to changesets after that
> means we see the 'new' octree particle deposition.
>
> -desika
>
>
> On Sat, Jun 14, 2014 at 2:13 PM, Matthew Turk <matthewturk at gmail.com> wrote:
>>
>> Hi all,
>>
>> As a quick note, on my laptop I found a regression in particle
>> deposition. The snapshot_033 ("deposit","all_density") is messed up.
>> It was my fault, as it came from changeset 2dc75b72d271 and is a
>> result of F/C ordering (and I can fix as soon as I am back at my desk
>> in an hour or so). Should only affect octree particle deposition,
>> went in very briefly, and I've CC'd everyone who might have been
>> affected in the last two days.
>>
>> But, to the point, I'm not sure why the answer testing didn't catch
>> this. Kacper, any ideas?
>>
>> -Matt
>
>
More information about the yt-dev
mailing list