[yt-dev] Update on Windows

[Matthew Turk]

Hi John,

Awesome work!  I think we can look at this as a PR any time you're
ready and take it from there, including the test stuff.  Very very
cool.

-Matt

On Tue, Dec 31, 2013 at 8:08 PM, John ZuHone <jzuhone at gmail.com> wrote:
> My apologies--Nathan has informed me that test definitely came in
> unitrefactor. Not sure how I did that, because I don't remember merging it
> in. However, my mercurial skills are still slightly less than kung-fu.
>
> Anyway, happy new year!
>
>
> John ZuHone
> Laboratory for High-Energy Astrophysics
> NASA/Goddard Space Flight Center
> 8800 Greenbelt Rd., Mail Code 662
> Greenbelt, MD 20771
> (w) 301-286-2531
> (m) 781-708-5004
> john.zuhone at nasa.gov
> jzuhone at gmail.com
>
> On Dec 31, 2013, at 7:51 PM, Nathan Goldbaum <nathan12343 at gmail.com> wrote:
>
> Hi John,
>
> If you take a look at Matt's fork, you'll see that I recently updated that
> unit test to compare to 12 decimal places instead of requiring bitwise
> identicality.  See this PR:
> https://bitbucket.org/MatthewTurk/yt/pull-request/6/unit-consistency-enzo-cosmology-units/diff
>
> I think if you merge with Matt (specifically, the unitrefactor bookmark on
> https://bitbucket.org/MatthewTurk/yt) that issue should go away.  Not sure
> if new issues will crop up.
>
> -Nathan
>
>
> On Tue, Dec 31, 2013 at 3:45 PM, John Zuhone <jzuhone at gmail.com> wrote:
>>
>> Hi all,
>>
>> Good news on the Windows/yt front. I'm happy to announce that as of
>> right now only one unit test is failing. The failure is subtle, but I
>> thought I would run it by you all to see what we should do about it.
>>
>> The failure in question is a comparison test in
>> yt/utilities/tests/test_units.py, in "test_power":
>>
>>     assert u2.cgs_value == (pc_cgs**2 * mK_cgs**4)**2
>>
>> basically, the unit cgs_value is exactly the combination of these
>> factors, so even though they are floats, one would expect that the
>> equality should hold, and on our other platforms it does. However, on
>> Windows, the comparison is failing on the last digit, with a relative
>> difference of ~4e-16 between the two values. So, while I'm not
>> inclined to be very concerned about it, I'm curious to see what you
>> guys think about how it should be handled.
>>
>> Happy New Year!
>>
>> John Z
>>
>> --
>> John ZuHone
>>
>> Postdoctoral Researcher
>> NASA/Goddard Space Flight Center
>>
>> jzuhone at gmail.com
>> john.zuhone at nasa.gov
>> _______________________________________________
>> yt-dev mailing list
>> yt-dev at lists.spacepope.org
>> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
>
>
> _______________________________________________
> yt-dev mailing list
> yt-dev at lists.spacepope.org
> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
>
>
> _______________________________________________
> yt-dev mailing list
> yt-dev at lists.spacepope.org
> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
>