[yt-dev] Move sanitization routines into coordinate handlers?

Matthew Turk matthewturk at gmail.com
Tue Aug 5 11:37:41 PDT 2014


Hi Nathan,

Fair enough.

I've been working through this and refactoring them, and I'll be
updating my PR not to be WIP as soon as I've finished.

One modification I'm considering making is allowing the center
sanitization to take an axis argument.

-Matt

On Tue, Aug 5, 2014 at 12:06 PM, Nathan Goldbaum <nathan12343 at gmail.com> wrote:
>
>
>
> On Tue, Aug 5, 2014 at 9:13 AM, Matthew Turk <matthewturk at gmail.com> wrote:
>>
>> Hi all, especially Nathan,
>>
>> What do you think about moving the functions:
>>
>> get_sanitized_center
>> get_sanitized_width
>
>
> I think it makes sense to put these in the coordinate handler.
>
>>
>> get_window_parameters
>> get_oblique_window_parameters
>
>
> Less so these.  Right now these functions have a lot of coordinate-specific
> logic in them, but I think most of that
> can be refactored into get_santized_center and get_sanitized_width.
>
>>
>>
>> into the coordinate handler (ds.coordinates)?  This would make it
>> easier to implement them more carefully and clearly for the different
>> coordinate systems, like spherical, cylindrical, etc.
>>
>> -Matt
>> _______________________________________________
>> yt-dev mailing list
>> yt-dev at lists.spacepope.org
>> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
>
>
>
> _______________________________________________
> yt-dev mailing list
> yt-dev at lists.spacepope.org
> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
>



More information about the yt-dev mailing list