[yt-dev] ramses conversion factors when boxlen isn't 1.0

[Matthew Turk]

Hi Nick,

I've gone over the code, and I *think* that those comments are now out
of date.  In fact, it will likely work if you simply change line 453,
which sets domain_right_edge, to multiply by self.parameters["boxlen"]
which gets read in from the file.  The other places this would be
important would be in the selection routines (which already use the
right/left edges and the domain dimensions so should be okay) and the
units.  Do the units need to be updated, or are they correctly set if
domain_right_edge is set?

Can you have a try at that, make sure it works, and then issue a PR?

-Matt

On Thu, Jul 4, 2013 at 7:08 AM, nick moeckel <nickolas1 at gmail.com> wrote:
> Hi there,
>
> I'm using 3.0 to analyse ramses data, and I have a few data sets where the
> box size in code units is not 1, i.e. in the info files that belong to each
> output I have, for example,
>
> boxlen      =  0.100000000000000E+02
>
> In this case, things like selecting a sphere in pc and calculating cell
> masses are off by factors of boxlen and boxlen**3.
>
> The comments  at the top of _parse_parameter_file (# hardcoded for now
>  These should be explicitly obtained from the file, but for now that will
> wait until a reorganization of the source tree and better generalization.)
> suggest that this might be fixed as part of a long term plan, but is there
> something that I could do to my own copy to deal with this in the
> short-term, or would it be best to just manually adjust anything that uses a
> length in my analysis scripts?
>
> best,
> Nick
>
> _______________________________________________
> yt-dev mailing list
> yt-dev at lists.spacepope.org
> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
>