[yt-users] yt-users Digest, Vol 97, Issue 12

[Slavin, Jonathan]

​Hi Matt,

Yeah, I think I'll take you up on your offer to issue the PR.

Thanks,
Jon​

On Tue, Mar 8, 2016 at 3:45 PM, <yt-users-request at lists.spacepope.org>
wrote:

> Date: Tue, 8 Mar 2016 14:41:42 -0600
> From: Matthew Turk <matthewturk at gmail.com>
> To: Discussion of the yt analysis package
>         <yt-users at lists.spacepope.org>
> Subject: Re: [yt-users] found the problem with non-square frb
> Message-ID:
>         <CALO3=5G0vR-=7G+KaQZo=
> Z5-7VoHngFZJvmbduensONdMcHbpQ at mail.gmail.com>
> Content-Type: text/plain; charset=UTF-8
>
> Hi Jon,
>
> That would be an awesome pull request, but I understand your
> reluctance.  I'm happy to issue it for you and credit you in the PR.
> :)
>
> -Matt
>
> On Tue, Mar 8, 2016 at 2:39 PM, Slavin, Jonathan
> <jslavin at cfa.harvard.edu> wrote:
> > Hi all,
> >
> > I just located the problem referred to in my earlier message.  There's a
> > very small bug in data_objects/data_containers.py
> > On lines 957 - 959 there is:
> >         elif iterable(height):
> >             h, u = height
> >             height = self.ds.quan(w, input_units = u)
> > Note the w in self.ds_quan(w, input_units = u).  Just replace that w
> with an
> > h and it works.  Should I file a pull request?  Seems a bit much for
> such a
> > minor bug, but I'm willing to do it.
> >
> > Jon
>




-- 
________________________________________________________
Jonathan D. Slavin                 Harvard-Smithsonian CfA
jslavin at cfa.harvard.edu       60 Garden Street, MS 83
phone: (617) 496-7981       Cambridge, MA 02138-1516
cell: (781) 363-0035             USA
________________________________________________________
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.spacepope.org/pipermail/yt-users-spacepope.org/attachments/20160308/6e851e85/attachment.htm>