[yt-users] Reviewing pull requests

[Nathan Goldbaum]

On Mon, Jun 27, 2016 at 4:42 PM, Stephanie Tonnesen <stonnes at gmail.com>
wrote:

> Hi Nathan,
>
> Thanks for the walk-through.  I think I am close.  I am looking at #2252.
> I just typed
>
> hg clone https://bitbucket.org/yt_analysis/ytcd yt
>
> hg update #2252
>
> And got the response
> 0 files updated, 0 files merged, 0 files removed, 0 files unresolved
>
> Which I think should have updated 2 files....So
> what I must be missing is the pulling the changes thing you talked about.
>
> Can you tell me about that?
>
>
#2252 is not a revision specifier. Mercurial doesn't know anything about
bitbucket pull requests.

Instead, you need to find the revision identifier for the most recent
commit in the pull request. For PR 2252, that changeset identifier
is 12998d8. You can see that if you look on the "commits" tab for the pull
request page on bitbucket.

Now to pull that change in locally, you can do:

$ hg pull -r 12998d8 https://bitbucket.org/brittonsmith/yt
$ hg up -C 12998d8
$ ./clean.sh
$ python setup.py develop

Hope that helps,

Nathan


>
> Thanks,
>
> Stephanie
>
>
>
> --
> Dr. Stephanie Tonnesen
> Alvin E. Nashman Postdoctoral Fellow
> Carnegie Observatories, Pasadena, CA
> stonnes at gmail.com
>
> On Mon, Jun 27, 2016 at 2:05 PM, Nathan Goldbaum <nathan12343 at gmail.com>
> wrote:
>
>>
>>
>> On Mon, Jun 27, 2016 at 4:01 PM, Stephanie Tonnesen <stonnes at gmail.com>
>> wrote:
>>
>>> Hi yt-users,
>>>
>>> So I am using the developers yt-conda version of yt.  I am trying to
>>> review a pull request, but have no idea what I am doing.  All I ever do is
>>>
>>> yt update
>>>
>>> I literally just broke yt 5 days ago, so I am a bit unwilling to just
>>> poke around trying out random hg commands to see what happens.  Is this
>>> what I am supposed to do once I have activated yt?
>>>
>>> hg clone https://bitbucket.org/yt_analysis/ytcd yt
>>> hg update yt
>>> python setup.py install --user --prefix=
>>>
>>> If you're going to be doing development, you probably want to do
>>
>> "python setup.py develop"
>>
>> I'd do "pip uninstall yt" first to delete the installation you put in
>> .local.
>>
>>
>>> And *if* this is right, how do I grab a specific change set?
>>>
>>
>> Rather than doing "hg update yt" (which will take you to the most recent
>> commit on the yt branch), you should do:
>>
>> $ hg update <revision>
>>
>> Where <revision> is e.g. a changeset hash or some other identifier.
>>
>> If you're trying to pull in a specific changeset to your local clone of
>> yt, you'll also need to pull the changes from the pull request into your
>> local clone of yt. Which pull request are you looking at?
>>
>>
>>>
>>> Thanks so much!
>>>
>>> Stephanie
>>>
>>> --
>>> Dr. Stephanie Tonnesen
>>> Alvin E. Nashman Postdoctoral Fellow
>>> Carnegie Observatories, Pasadena, CA
>>> stonnes at gmail.com
>>>
>>> _______________________________________________
>>> yt-users mailing list
>>> yt-users at lists.spacepope.org
>>> http://lists.spacepope.org/listinfo.cgi/yt-users-spacepope.org
>>>
>>>
>>
>> _______________________________________________
>> yt-users mailing list
>> yt-users at lists.spacepope.org
>> http://lists.spacepope.org/listinfo.cgi/yt-users-spacepope.org
>>
>>
>
> _______________________________________________
> yt-users mailing list
> yt-users at lists.spacepope.org
> http://lists.spacepope.org/listinfo.cgi/yt-users-spacepope.org
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.spacepope.org/pipermail/yt-users-spacepope.org/attachments/20160627/bd7e0d94/attachment.htm>