[yt-svn] commit/yt: ngoldbaum: Merged in atmyers/yt (pull request #2144)
commits-noreply at bitbucket.org
commits-noreply at bitbucket.org
Fri Apr 29 08:41:02 PDT 2016
1 new commit in yt:
https://bitbucket.org/yt_analysis/yt/commits/a3c2f4884d53/
Changeset: a3c2f4884d53
Branch: yt
User: ngoldbaum
Date: 2016-04-29 15:40:55+00:00
Summary: Merged in atmyers/yt (pull request #2144)
[DOCS] Add paragraph to the developing docs about best practices for generating new answers.
Affected #: 1 file
diff -r b02a8c47c9d06013580dba4e5d559a5974d37ccb -r a3c2f4884d539e346255fbbb84117980d8d7719e doc/source/developing/testing.rst
--- a/doc/source/developing/testing.rst
+++ b/doc/source/developing/testing.rst
@@ -532,7 +532,13 @@
local_pw_000:
-would regenerate answers for OWLS frontend.
+would regenerate answers for OWLS frontend.
+
+When adding tests to an existing set of answers (like ``local_owls_000`` or ``local_varia_000``),
+it is considered best practice to first submit a pull request adding the tests WITHOUT incrementing
+the version number. Then, allow the tests to run (resulting in "no old answer" errors for the missing
+answers). If no other failures are present, you can then increment the version number to regenerate
+the answers. This way, we can avoid accidently covering up test breakages.
Adding New Answer Tests
~~~~~~~~~~~~~~~~~~~~~~~
Repository URL: https://bitbucket.org/yt_analysis/yt/
--
This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.spacepope.org/pipermail/yt-svn-spacepope.org/attachments/20160429/b44b2339/attachment.htm>
More information about the yt-svn
mailing list