[yt-svn] commit/yt: 2 new changesets

Bitbucket commits-noreply at bitbucket.org
Fri Nov 9 14:58:13 PST 2012


2 new commits in yt:


https://bitbucket.org/yt_analysis/yt/changeset/4a1149df9e93/
changeset:   4a1149df9e93
branch:      yt
user:        samskillman
date:        2012-11-09 23:56:24
summary:     Remove unused variables, and resolves the current build error.
affected #:  1 file

diff -r 4ea60322c0c434459a522973f9f2be732ed66555 -r 4a1149df9e9308d2fb0cdaf7d3c46dd069d62e69 yt/utilities/answer_testing/framework.py
--- a/yt/utilities/answer_testing/framework.py
+++ b/yt/utilities/answer_testing/framework.py
@@ -94,9 +94,6 @@
             AnswerTestingTest.reference_storage = \
                 self.storage = AnswerTestCloudStorage(options.compare_name, not options.store_results)
 
-        self.storage_compare_name = options.compare_name
-        self.output_dir = options.output_dir
-        self.answer_name = options.this_name
         self.store_results = options.store_results
         self.store_local_results = options.store_local_results
         global run_big_data



https://bitbucket.org/yt_analysis/yt/changeset/76614f8362da/
changeset:   76614f8362da
branch:      yt
user:        samskillman
date:        2012-11-09 23:57:08
summary:     Merging.
affected #:  2 files

diff -r 4a1149df9e9308d2fb0cdaf7d3c46dd069d62e69 -r 76614f8362daaa33f2ca07c370a0fdb554dd91f4 .hgtags
--- a/.hgtags
+++ b/.hgtags
@@ -5152,3 +5152,6 @@
 0000000000000000000000000000000000000000 svn.993
 fff7118f00e25731ccf37cba3082b8fcb73cf90e svn.371
 0000000000000000000000000000000000000000 svn.371
+f15825659f5af3ce64aaad30062aff3603cbfb66 hop callback
+0000000000000000000000000000000000000000 hop callback
+0000000000000000000000000000000000000000 hop callback


diff -r 4a1149df9e9308d2fb0cdaf7d3c46dd069d62e69 -r 76614f8362daaa33f2ca07c370a0fdb554dd91f4 yt/utilities/parallel_tools/parallel_analysis_interface.py
--- a/yt/utilities/parallel_tools/parallel_analysis_interface.py
+++ b/yt/utilities/parallel_tools/parallel_analysis_interface.py
@@ -279,12 +279,12 @@
     ranks = None
     available_ranks = None
     tasks = None
-    workgroups = []
     def __init__(self):
         self.comm = communication_system.communicators[-1]
         self.size = self.comm.size
         self.ranks = range(self.size)
         self.available_ranks = range(self.size)
+        self.workgroups = []
     
     def add_workgroup(self, size=None, ranks=None, name=None):
         if size is None:
@@ -296,7 +296,7 @@
             ranks = [self.available_ranks.pop(0) for i in range(size)]
         # Default name to the workgroup number.
         if name is None: 
-            name = string(len(workgroups))
+            name = string(len(self.workgroups))
         group = self.comm.comm.Get_group().Incl(ranks)
         new_comm = self.comm.comm.Create(group)
         if self.comm.rank in ranks:
@@ -304,16 +304,20 @@
         self.workgroups.append(Workgroup(len(ranks), ranks, new_comm, name))
     
     def free_workgroup(self, workgroup):
+        # If you want to actually delete the workgroup you will need to
+        # pop it out of the self.workgroups list so you don't have references
+        # that are left dangling, e.g. see free_all() below.
         for i in workgroup.ranks:
             if self.comm.rank == i:
                 communication_system.communicators.pop()
             self.available_ranks.append(i) 
-        del workgroup
         self.available_ranks.sort()
 
     def free_all(self):
         for wg in self.workgroups:
             self.free_workgroup(wg)
+        for i in range(len(self.workgroups)):
+            self.workgroups.pop(0)
 
     @classmethod
     def from_sizes(cls, sizes):

Repository URL: https://bitbucket.org/yt_analysis/yt/

--

This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.



More information about the yt-svn mailing list