[Yt-svn] yt-commit r1460 - in trunk/yt: . lagos

mturk at wrangler.dreamhost.com mturk at wrangler.dreamhost.com
Sat Sep 26 19:39:39 PDT 2009


Author: mturk
Date: Sat Sep 26 19:39:38 2009
New Revision: 1460
URL: http://yt.enzotools.org/changeset/1460

Log:
Turned off progress bars for parallel processes; there's some indication that
the IO buffering here causes performance degradation.



Modified:
   trunk/yt/funcs.py
   trunk/yt/lagos/ParallelTools.py

Modified: trunk/yt/funcs.py
==============================================================================
--- trunk/yt/funcs.py	(original)
+++ trunk/yt/funcs.py	Sat Sep 26 19:39:38 2009
@@ -133,15 +133,24 @@
             local_ns = loc, global_ns = glo)
     del ipshell
 
-class DummyProgressBar:
+class DummyProgressBar(object):
     def __init__(self, *args, **kwargs):
         return
     def update(self, *args, **kwargs):
         return
-    def finish(sefl, *args, **kwargs):
+    def finish(self, *args, **kwargs):
         return
 
-class GUIProgressBar:
+class ParallelProgressBar(object):
+    def __init__(self, title, maxval):
+        self.title = title
+        mylog.info("Starting '%s'", title)
+    def update(self, *args, **kwargs):
+        return
+    def finish(self):
+        mylog.info("Finishing '%s'", self.title)
+
+class GUIProgressBar(object):
     def __init__(self, title, maxval):
         import wx
         self.maxval = maxval
@@ -174,6 +183,8 @@
             return DummyProgressBar()
     elif ytcfg.getboolean("yt","suppressStreamLogging"):
         return DummyProgressBar()
+    elif ytcfg.getboolean("yt", "__parallel"):
+        return ParallelProgressBar(title, maxval)
     elif "SAGE_ROOT" in os.environ:
         try:
             from sage.server.support import EMBEDDED_MODE

Modified: trunk/yt/lagos/ParallelTools.py
==============================================================================
--- trunk/yt/lagos/ParallelTools.py	(original)
+++ trunk/yt/lagos/ParallelTools.py	Sat Sep 26 19:39:38 2009
@@ -53,6 +53,9 @@
         f = logging.Formatter("P%03i %s" % (MPI.COMM_WORLD.rank,
                                             yt.logger.fstring))
         yt.logger.rootLogger.handlers[0].setFormatter(f)
+    if ytcfg.getint("yt","LogLevel") < 20:
+        yt.logger.ytLogger.warning(
+          "Log Level is set low -- this could affect parallel performance!")
 else:
     parallel_capable = False
 



More information about the yt-svn mailing list