<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta content="text/html; charset=utf-8">
</head>
<body>
<style type="text/css">
<!--
p
{font-family:Calibri,Arial,Helvetica,sans-serif;
font-size:12.0pt;
color:#000000}
-->
</style>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12.0pt; color:#000000">
<p dir="ltr">+1<br>
</p>
<div id="signature-x" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12.0pt; color:#000000">
<div><style id="edit-style">
<!--
ol, ul
{margin:0px}
-->
</style>
<div><span style="color:rgb(0,0,0); font-family:sans-serif; font-style:normal; font-variant:normal; font-weight:normal; letter-spacing:normal; line-height:normal; orphans:auto; text-align:start; text-indent:0px; text-transform:none; white-space:normal; widows:1; word-spacing:0px; display:inline!important; float:none; font-size:10.0pt">--</span><span style="color:rgb(0,0,0); font-family:sans-serif; font-style:normal; font-variant:normal; font-weight:normal; letter-spacing:normal; line-height:normal; orphans:auto; text-align:start; text-indent:0px; text-transform:none; white-space:normal; widows:1; word-spacing:0px; display:inline!important; float:none; font-size:9.0pt"><span class="Apple-converted-space" style="font-size:14.0pt"> </span></span><br>
<span style="color:rgb(0,0,0); font-family:sans-serif; font-style:normal; font-variant:normal; font-weight:normal; letter-spacing:normal; line-height:normal; orphans:auto; text-align:start; text-indent:0px; text-transform:none; white-space:normal; widows:1; word-spacing:0px; display:inline!important; float:none; font-size:10.0pt">John
Wise<span class="Apple-converted-space"> </span></span><br>
<span style="color:rgb(0,0,0); font-family:sans-serif; font-style:normal; font-variant:normal; font-weight:normal; letter-spacing:normal; line-height:normal; orphans:auto; text-align:start; text-indent:0px; text-transform:none; white-space:normal; widows:1; word-spacing:0px; display:inline!important; float:none; font-size:10.0pt">Associate
Professor of Physics<span class="Apple-converted-space"> </span></span><br>
<span style="color:rgb(0,0,0); font-family:sans-serif; font-style:normal; font-variant:normal; font-weight:normal; letter-spacing:normal; line-height:normal; orphans:auto; text-align:start; text-indent:0px; text-transform:none; white-space:normal; widows:1; word-spacing:0px; display:inline!important; float:none; font-size:10.0pt">Center
for Relativistic Astrophysics, Georgia Tech<span class="Apple-converted-space"> </span></span><br>
<a href="http://cosmo.gatech.edu/" style="font-family:sans-serif; font-style:normal; font-variant:normal; font-weight:normal; letter-spacing:normal; line-height:normal; orphans:auto; text-align:start; text-indent:0px; text-transform:none; white-space:normal; widows:1; word-spacing:0px; font-size:10.0pt">http://cosmo.gatech.edu</a><br>
</div>
<br>
</div>
</div>
</div>
<div id="quoted_header" style="clear:both">
<hr style="border:none; height:1px; color:#E1E1E1; background-color:#E1E1E1">
<div style="border:none; padding:3.0pt 0cm 0cm 0cm"><span style="font-size:11.0pt; font-family:'Calibri','sans-serif'"><b>From:</b> Nathan Goldbaum <nathan12343@gmail.com><br>
<b>Sent:</b> Oct 28, 2016 12:34<br>
<b>To:</b> yt-dev@lists.spacepope.org<br>
<b>Subject:</b> [yt-dev] Forward pull request created e-mails to the yt-dev mailing list<br>
</span></div>
</div>
<br type="attribution">
<div>
<div dir="ltr">Hi all,
<div><br>
</div>
<div>I've noticed recently a distinct downturn in the number of pull request reviews. That's not to implicate anyone and is not a value judgement on anyone's contribution. It simply reflects that people have other things to work and focus on. I happily acknowledge
that doing code review regularly is a tall order.</div>
<div><br>
</div>
<div>I'd like to make it so there's more of a culture of doing "drive-by" code review. I think one of the main reasons only a few people regularly do code review is that only a few people want to brave the e-mail onslaught and subscribe to all pull request
notifications on the yt_analysis/yt repository.</div>
<div><br>
</div>
<div>Instead, I'd like to propose a hopefully lower noise alternative: forward notifications about new pull requests to this mailing list. I think it's straightforward to add this via a webhook on the yt_analysis/yt repository.</div>
<div><br>
</div>
<div>We already have similar notifications when an issue is created. This is good and it encourages more people to look at new issues and offer a helping hand if they know what to do. I think having a similar setup for pull requests will encourage more people
to regularly pop in and take note of new code contributions since they'll be newly aware that they are happening.</div>
<div><br>
</div>
<div>Let me know what you think, especially if you are against the proposal.</div>
<div><br>
</div>
<div>-Nathan</div>
</div>
</div>
</body>
</html>