<div dir="ltr">+1 on new PRs to this list.</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 28, 2016 at 10:08 AM, Wise, John H <span dir="ltr"><<a href="mailto:jwise@physics.gatech.edu" target="_blank">jwise@physics.gatech.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">




<div>

<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12.0pt;color:#000000">
<p dir="ltr">+1<span class="HOEnZb"><font color="#888888"><br>
</font></span></p><span class="HOEnZb"><font color="#888888">
<div id="m_9157328288462096317signature-x" style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12.0pt;color:#000000">
<div>
<div><span style="color:rgb(0,0,0);font-family:sans-serif;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;display:inline!important;float:none;font-size:10.0pt">--</span><span style="color:rgb(0,0,0);font-family:sans-serif;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;display:inline!important;float:none;font-size:9.0pt"><span class="m_9157328288462096317Apple-converted-space" style="font-size:14.0pt"> </span></span><br>
<span style="color:rgb(0,0,0);font-family:sans-serif;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;display:inline!important;float:none;font-size:10.0pt">John
 Wise<span class="m_9157328288462096317Apple-converted-space"> </span></span><br>
<span style="color:rgb(0,0,0);font-family:sans-serif;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;display:inline!important;float:none;font-size:10.0pt">Associate
 Professor of Physics<span class="m_9157328288462096317Apple-converted-space"> </span></span><br>
<span style="color:rgb(0,0,0);font-family:sans-serif;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;display:inline!important;float:none;font-size:10.0pt">Center
 for Relativistic Astrophysics, Georgia Tech<span class="m_9157328288462096317Apple-converted-space"> </span></span><br>
<a href="http://cosmo.gatech.edu/" style="font-family:sans-serif;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;font-size:10.0pt" target="_blank">http://cosmo.gatech.edu</a><br>
</div>
<br>
</div>
</div>
</font></span></div><span class="HOEnZb"><font color="#888888">
<div id="m_9157328288462096317quoted_header" style="clear:both">
<hr style="border:none;height:1px;color:#e1e1e1;background-color:#e1e1e1">
<div style="border:none;padding:3.0pt 0cm 0cm 0cm"><span style="font-size:11.0pt;font-family:'Calibri','sans-serif'"><b>From:</b> Nathan Goldbaum <<a href="mailto:nathan12343@gmail.com" target="_blank">nathan12343@gmail.com</a>><br>
<b>Sent:</b> Oct 28, 2016 12:34<br>
<b>To:</b> <a href="mailto:yt-dev@lists.spacepope.org" target="_blank">yt-dev@lists.spacepope.org</a><br>
<b>Subject:</b> [yt-dev] Forward pull request created e-mails to the yt-dev mailing list<br>
</span></div>
</div></font></span><div><div class="h5">
<br type="attribution">
<div>
<div dir="ltr">Hi all,
<div><br>
</div>
<div>I've noticed recently a distinct downturn in the number of pull request reviews. That's not to implicate anyone and is not a value judgement on anyone's contribution. It simply reflects that people have other things to work and focus on. I happily acknowledge
 that doing code review regularly is a tall order.</div>
<div><br>
</div>
<div>I'd like to make it so there's more of a culture of doing "drive-by" code review. I think one of the main reasons only a few people regularly do code review is that only a few people want to brave the e-mail onslaught and subscribe to all pull request
 notifications on the yt_analysis/yt repository.</div>
<div><br>
</div>
<div>Instead, I'd like to propose a hopefully lower noise alternative: forward notifications about new pull requests to this mailing list. I think it's straightforward to add this via a webhook on the yt_analysis/yt repository.</div>
<div><br>
</div>
<div>We already have similar notifications when an issue is created. This is good and it encourages more people to look at new issues and offer a helping hand if they know what to do. I think having a similar setup for pull requests will encourage more people
 to regularly pop in and take note of new code contributions since they'll be newly aware that they are happening.</div>
<div><br>
</div>
<div>Let me know what you think, especially if you are against the proposal.</div>
<div><br>
</div>
<div>-Nathan</div>
</div>
</div>
</div></div></div>

<br>______________________________<wbr>_________________<br>
yt-dev mailing list<br>
<a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" rel="noreferrer" target="_blank">http://lists.spacepope.org/<wbr>listinfo.cgi/yt-dev-spacepope.<wbr>org</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div>Cameron Hummels<div><span style="font-size:12.8000001907349px">NSF Postdoctoral Fellow</span></div><div><span style="font-size:12.8000001907349px">Department of Astronomy</span></div><div><span style="font-size:12.8000001907349px">California Institute of Technology</span><br></div><div><a href="http://chummels.org" style="font-size:12.8000001907349px" target="_blank">http://chummels.org</a><br></div></div></div></div>
</div>