<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">+1 for lowering the barrier. At a minimum, tests should pass, and new tests should be encouraged if possible. Docs as well.<div class=""><br class=""></div><div class="">Not too worried about 1 or 2 approvals. We could try 2 at first to see if this helps things out. </div><div class=""><br class=""></div><div class=""><div><blockquote type="cite" class=""><div class="">On Dec 29, 2015, at 5:39 PM, Cameron Hummels <<a href="mailto:chummels@gmail.com" class="">chummels@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">As long as the code being changed is local to an analysis module and not used by other parts of the main yt codebase, yes, I'm all for dropping the 3 reviewer requirement to 2. 1 might be pushing it though.</div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Dec 29, 2015 at 2:38 PM, Matthew Turk <span dir="ltr" class=""><<a href="mailto:matthewturk@gmail.com" target="_blank" class="">matthewturk@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">That's precisely what I had in mind.<br class="">
<div class="HOEnZb"><div class="h5"><br class="">
On Tue, Dec 29, 2015 at 4:36 PM, Nathan Goldbaum <<a href="mailto:nathan12343@gmail.com" class="">nathan12343@gmail.com</a>> wrote:<br class="">
> On Tue, Dec 29, 2015 at 4:29 PM, Matthew Turk <<a href="mailto:matthewturk@gmail.com" class="">matthewturk@gmail.com</a>> wrote:<br class="">
>><br class="">
>> [+-][01] on reducing review overhead for analysis modules?<br class="">
><br class="">
><br class="">
> Does this just mean reducing the number of PR reviewers before we merge pull<br class="">
> requests? I'd be ok with that, but just want to clarify what you have in<br class="">
> mind.<br class="">
><br class="">
</div></div><div class="HOEnZb"><div class="h5">> _______________________________________________<br class="">
> yt-dev mailing list<br class="">
> <a href="mailto:yt-dev@lists.spacepope.org" class="">yt-dev@lists.spacepope.org</a><br class="">
> <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.spacepope.org_listinfo.cgi_yt-2Ddev-2Dspacepope.org&d=BQMFAg&c=8hUWFZcy2Z-Za5rBPlktOQ&r=hgcBC3x6dKFoTrmFmMYYbKNfiHZlGLKliIidd1LwmHI&m=7fyDqWeL_GeRQzwcNJri7DaWLqJ_IgQixFA8ankoPQ8&s=kM3PrALLVzXzzRJ__QUlvkDetGYySDO-lacgWh10nno&e=" rel="noreferrer" target="_blank" class="">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br class="">
><br class="">
_______________________________________________<br class="">
yt-dev mailing list<br class="">
<a href="mailto:yt-dev@lists.spacepope.org" class="">yt-dev@lists.spacepope.org</a><br class="">
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.spacepope.org_listinfo.cgi_yt-2Ddev-2Dspacepope.org&d=BQMFAg&c=8hUWFZcy2Z-Za5rBPlktOQ&r=hgcBC3x6dKFoTrmFmMYYbKNfiHZlGLKliIidd1LwmHI&m=7fyDqWeL_GeRQzwcNJri7DaWLqJ_IgQixFA8ankoPQ8&s=kM3PrALLVzXzzRJ__QUlvkDetGYySDO-lacgWh10nno&e=" rel="noreferrer" target="_blank" class="">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br class="">
</div></div></blockquote></div><br class=""><br clear="all" class=""><div class=""><br class=""></div>-- <br class=""><div class="gmail_signature"><div dir="ltr" class=""><div class="">Cameron Hummels<div class=""><span style="font-size:12.8000001907349px" class="">NSF Postdoctoral Fellow</span></div><div class=""><span style="font-size:12.8000001907349px" class="">Department of Astronomy</span></div><div class=""><span style="font-size:12.8000001907349px" class="">California Institute of Technology</span><br class=""></div><div class=""><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__chummels.org_&d=BQMFAg&c=8hUWFZcy2Z-Za5rBPlktOQ&r=hgcBC3x6dKFoTrmFmMYYbKNfiHZlGLKliIidd1LwmHI&m=7fyDqWeL_GeRQzwcNJri7DaWLqJ_IgQixFA8ankoPQ8&s=n9VlZttYtcPN-Sm1_xEb3ubbkAoK-MgemTSstEPSTDY&e=" style="font-size:12.8000001907349px" target="_blank" class="">http://chummels.org</a><br class=""></div></div></div></div>
</div>
_______________________________________________<br class="">yt-dev mailing list<br class=""><a href="mailto:yt-dev@lists.spacepope.org" class="">yt-dev@lists.spacepope.org</a><br class="">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org<br class=""></div></blockquote></div><br class=""></div></body></html>