<meta http-equiv="Content-Type" content="text/html; charset=utf-8">I agree. If we can identify maintainers for analysis modules, I think only one additional approval besides the maintainer is fine. If the maintainer proposes the PR, they should try to get at least one person <span></span>to look over it in detail before it gets merged.<div><br>On Tuesday, December 29, 2015, Britton Smith <<a href="mailto:brittonsmith@gmail.com">brittonsmith@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I agree that the number of approvals is less important than ensuring that PRs come with appropriate tests and docs.  If the PR is a change to an existing analysis module, we should just make sure the relevant devs are identified and that they sign off on it.  If it's something brand new, I think 2 or 3 people is probably still a good idea.</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Dec 29, 2015 at 4:44 PM, Matthew Turk <span dir="ltr"><<a href="javascript:_e(%7B%7D,'cvml','matthewturk@gmail.com');" target="_blank">matthewturk@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Ideally, with the barrier to acceptance reduced, the reviews that come<br>
in may be deeper and more thoughtful ... and less along the lines of<br>
"Can somebody just hit the approve button?"<br>
<div><div><br>
On Tue, Dec 29, 2015 at 4:41 PM, John ZuHone <<a href="javascript:_e(%7B%7D,'cvml','jzuhone@gmail.com');" target="_blank">jzuhone@gmail.com</a>> wrote:<br>
> +1 for lowering the barrier. At a minimum, tests should pass, and new tests<br>
> should be encouraged if possible. Docs as well.<br>
><br>
> Not too worried about 1 or 2 approvals. We could try 2 at first to see if<br>
> this helps things out.<br>
><br>
> On Dec 29, 2015, at 5:39 PM, Cameron Hummels <<a href="javascript:_e(%7B%7D,'cvml','chummels@gmail.com');" target="_blank">chummels@gmail.com</a>> wrote:<br>
><br>
> As long as the code being changed is local to an analysis module and not<br>
> used by other parts of the main yt codebase, yes, I'm all for dropping the 3<br>
> reviewer requirement to 2.  1 might be pushing it though.<br>
><br>
> On Tue, Dec 29, 2015 at 2:38 PM, Matthew Turk <<a href="javascript:_e(%7B%7D,'cvml','matthewturk@gmail.com');" target="_blank">matthewturk@gmail.com</a>> wrote:<br>
>><br>
>> That's precisely what I had in mind.<br>
>><br>
>> On Tue, Dec 29, 2015 at 4:36 PM, Nathan Goldbaum <<a href="javascript:_e(%7B%7D,'cvml','nathan12343@gmail.com');" target="_blank">nathan12343@gmail.com</a>><br>
>> wrote:<br>
>> > On Tue, Dec 29, 2015 at 4:29 PM, Matthew Turk <<a href="javascript:_e(%7B%7D,'cvml','matthewturk@gmail.com');" target="_blank">matthewturk@gmail.com</a>><br>
>> > wrote:<br>
>> >><br>
>> >> [+-][01] on reducing review overhead for analysis modules?<br>
>> ><br>
>> ><br>
>> > Does this just mean reducing the number of PR reviewers before we merge<br>
>> > pull<br>
>> > requests? I'd be ok with that, but just want to clarify what you have in<br>
>> > mind.<br>
>> ><br>
>> > _______________________________________________<br>
>> > yt-dev mailing list<br>
>> > <a href="javascript:_e(%7B%7D,'cvml','yt-dev@lists.spacepope.org');" target="_blank">yt-dev@lists.spacepope.org</a><br>
>> > <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.spacepope.org_listinfo.cgi_yt-2Ddev-2Dspacepope.org&d=BQMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=hgcBC3x6dKFoTrmFmMYYbKNfiHZlGLKliIidd1LwmHI&m=HVxZK1ypz0IJr4SMvNMs5Gqvvr38d_G1G5BEhnrpvic&s=zKC2jJ9bdbZoyXtjjKkDTwhnnBmrWcXwFLd4rttmBOI&e=" rel="noreferrer" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
>> ><br>
>> _______________________________________________<br>
>> yt-dev mailing list<br>
>> <a href="javascript:_e(%7B%7D,'cvml','yt-dev@lists.spacepope.org');" target="_blank">yt-dev@lists.spacepope.org</a><br>
>> <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.spacepope.org_listinfo.cgi_yt-2Ddev-2Dspacepope.org&d=BQMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=hgcBC3x6dKFoTrmFmMYYbKNfiHZlGLKliIidd1LwmHI&m=HVxZK1ypz0IJr4SMvNMs5Gqvvr38d_G1G5BEhnrpvic&s=zKC2jJ9bdbZoyXtjjKkDTwhnnBmrWcXwFLd4rttmBOI&e=" rel="noreferrer" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
><br>
><br>
><br>
><br>
> --<br>
> Cameron Hummels<br>
> NSF Postdoctoral Fellow<br>
> Department of Astronomy<br>
> California Institute of Technology<br>
> <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__chummels.org&d=BQMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=hgcBC3x6dKFoTrmFmMYYbKNfiHZlGLKliIidd1LwmHI&m=HVxZK1ypz0IJr4SMvNMs5Gqvvr38d_G1G5BEhnrpvic&s=CoUQgRZxn1r_g6K-gTIplKvDURTAA04vP5herAHHfOo&e=" rel="noreferrer" target="_blank">http://chummels.org</a><br>
> _______________________________________________<br>
> yt-dev mailing list<br>
> <a href="javascript:_e(%7B%7D,'cvml','yt-dev@lists.spacepope.org');" target="_blank">yt-dev@lists.spacepope.org</a><br>
> <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.spacepope.org_listinfo.cgi_yt-2Ddev-2Dspacepope.org&d=BQMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=hgcBC3x6dKFoTrmFmMYYbKNfiHZlGLKliIidd1LwmHI&m=HVxZK1ypz0IJr4SMvNMs5Gqvvr38d_G1G5BEhnrpvic&s=zKC2jJ9bdbZoyXtjjKkDTwhnnBmrWcXwFLd4rttmBOI&e=" rel="noreferrer" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
><br>
><br>
><br>
> _______________________________________________<br>
> yt-dev mailing list<br>
> <a href="javascript:_e(%7B%7D,'cvml','yt-dev@lists.spacepope.org');" target="_blank">yt-dev@lists.spacepope.org</a><br>
> <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.spacepope.org_listinfo.cgi_yt-2Ddev-2Dspacepope.org&d=BQMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=hgcBC3x6dKFoTrmFmMYYbKNfiHZlGLKliIidd1LwmHI&m=HVxZK1ypz0IJr4SMvNMs5Gqvvr38d_G1G5BEhnrpvic&s=zKC2jJ9bdbZoyXtjjKkDTwhnnBmrWcXwFLd4rttmBOI&e=" rel="noreferrer" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
><br>
_______________________________________________<br>
yt-dev mailing list<br>
<a href="javascript:_e(%7B%7D,'cvml','yt-dev@lists.spacepope.org');" target="_blank">yt-dev@lists.spacepope.org</a><br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.spacepope.org_listinfo.cgi_yt-2Ddev-2Dspacepope.org&d=BQMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=hgcBC3x6dKFoTrmFmMYYbKNfiHZlGLKliIidd1LwmHI&m=HVxZK1ypz0IJr4SMvNMs5Gqvvr38d_G1G5BEhnrpvic&s=zKC2jJ9bdbZoyXtjjKkDTwhnnBmrWcXwFLd4rttmBOI&e=" rel="noreferrer" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
</div></div></blockquote></div><br></div>
</blockquote></div>