<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">I think that the fact that we have two equally fairly complex naming schemes here is a sign that we need to have a better way of organizing fields in different coordinate systems, but in the absence of a clear proposal for this I guess I would go with Option #1. <div class=""><br class=""></div><div class=""><div><blockquote type="cite" class=""><div class="">On Jan 3, 2015, at 5:30 PM, Andrew Myers <<a href="mailto:atmyers2@gmail.com" class="">atmyers2@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">I think both conventions are good, but I slightly prefer #1 (Nathan's naming) for being closer to what is done for Cartesian vector fields. </div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Sat, Jan 3, 2015 at 11:03 AM, Nathan Goldbaum <span dir="ltr" class=""><<a href="mailto:nathan12343@gmail.com" target="_blank" class="">nathan12343@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="">Hi all,<div class=""><br class=""></div><div class="">Since this is one of the blockers for 3.1, I'd like to bump this thread. It looks like we're now at 3 votes for my proposal and 2 votes for Cameron's proposal.</div><div class=""><br class=""></div><div class="">It would be great if a few more people could weigh in. Take a look at Cameron's e-mail near the top of this thread if you need a reminder.</div><span class="HOEnZb"><font color="#888888" class=""><div class=""><br class=""></div><div class="">-Nathan</div></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br class=""><div class="gmail_quote">On Mon, Dec 29, 2014 at 1:52 PM, Ben Thompson <span dir="ltr" class=""><<a href="mailto:bthompson2090@gmail.com" target="_blank" class="">bthompson2090@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class=""><div class=""><div class=""><div class=""><div class=""><div class="">Hey all.<br class=""><br class=""></div>Nathan, thank you for setting this up, Cameron thank you for clearly outlining the naming conventions, and sorry to you all if I have been a bit quiet recently.<br class=""><br class=""></div>I am for option #1 which to me feels a bit more natural to go particle -> vector field -> coordinate system -> coordinate<br class=""><br class=""></div>As Britton has said, it would be best to finalise a decision in the new year (maybe at the end of the first full week? say the 8th?).<br class=""><br class=""></div>This PR in question also corrects numerical computation in the particle_spherical co-ordinate system too as well as updatin the field naming YTEP, so is also important to get out in it's own right.<span class=""><font color="#888888" class=""><br class=""><br class=""></font></span></div><span class=""><font color="#888888" class="">Ben<br class=""><div class=""><div class=""><div class=""><div class=""><br class=""><br class=""><br class=""><br class=""></div></div></div></div></font></span></div><div class=""><div class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Wed, Dec 24, 2014 at 5:14 AM, Sam Skillman <span dir="ltr" class=""><<a href="mailto:samskillman@gmail.com" target="_blank" class="">samskillman@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi all, I agree with Britton here that it would be good to table this until folks have time to read through this carefully. Thanks, Sam<div class=""><div class=""><br class=""><br class=""><div class="gmail_quote">On Tue Dec 23 2014 at 2:40:41 PM Britton Smith <<a href="mailto:brittonsmith@gmail.com" target="_blank" class="">brittonsmith@gmail.com</a>> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="">I choose option #1.<div class=""><br class=""></div><div class="">Also, let's not be too quick to make big decisions here. Many people are on break right now and so are unavailable, or are wanting to be.</div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Dec 23, 2014 at 3:42 PM, Nathan Goldbaum <span dir="ltr" class=""><<a href="mailto:nathan12343@gmail.com" target="_blank" class="">nathan12343@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class=""><br class=""><div class="gmail_extra"><br class=""><div class="gmail_quote"><span class="">On Tue, Dec 23, 2014 at 1:33 PM, Matthew Turk <span dir="ltr" class=""><<a href="mailto:matthewturk@gmail.com" target="_blank" class="">matthewturk@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="">Hi Cameron,<div class="gmail_extra"><br class=""><div class="gmail_quote"><span class="">On Tue, Dec 23, 2014 at 11:56 AM, Cameron Hummels <span dir="ltr" class=""><<a href="mailto:chummels@gmail.com" target="_blank" class="">chummels@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="">Hi Nathan,<div class=""><br class=""></div><div class="">Thanks for your hard work on this PR (along with Ben Thompson). The naming convention that I suggested in the issue a few weeks back (<a href="https://bitbucket.org/yt_analysis/yt/issue/947/consistent-field-naming-for-spherical-and" style="font-size:13px" target="_blank" class="">https://bitbucket.org/yt_analysis/yt/issue/947/consistent-field-naming-for-spherical-and</a>) and in the discussion on your PR also matches with past convention. It is slightly different than what you propose, but seems (to me at least) to be more easy to read because the adjective comes before the noun (e.g. spherical position) instead of the reverse (e.g. position spherical).</div><div class=""><br class=""></div></div></blockquote><div class=""><br class=""></div></span><div class="">I'm neutral to both of these, in that I am broadly neutral about the increasingly nested set of modifiers. If forced, I think I'd go with your proposed convention.</div></div></div></div></blockquote><div class=""><br class=""></div></span><div class="">That's two votes against my convention (Cameron and Matt). If no one else pipes up in favor of my convention in the next day or so, I'll go ahead and create a YTEP PR and update my PR to match. This means we need to deprecate fewer fields, so it's probably simpler in the end...</div><span class=""><div class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""><br class=""></div><div class="">What would be a lot nicer, in my opinion, would be if we had a way to do this more generically. Like,</div><div class=""><br class=""></div><div class="">with data_object.rotate( ... ):</div><div class=""> prof1d = create_profile(data_object, "particle_position_x", "particle_mass")</div></div></div></div></blockquote><div class=""><br class=""></div></span><div class="">This is a much nicer syntax. We should consider this for a future release. If someone puts together a prototype for using data objects with context managers like this, I think we can have a big usability win for a lot of use cases.</div><div class=""><br class=""></div><div class="">Unfortunately we would probably still need to accept the names with modifiers for backward compatibility.</div><div class=""><div class=""><div class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""><br class=""></div><div class="">and then just get rid of all the nested modified field names. But I don't really think this is feasible.</div><div class=""><br class=""></div><div class="">-Matt</div><div class=""><div class=""><div class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class=""><div class=""></div><div class="">Where proposed naming convention #1 is:</div><div class=""><br class=""></div><div class=""><span style="font-size:13px" class="">(field_type, "<particle?>_<position/velocity>_<coordinate_system</span><span style="font-size:13px" class="">>_<coordinate>") e.g. ('all', 'particle_position_spherical_phi')</span><br class=""></div><div class=""><span style="font-size:13px" class=""><br class=""></span></div><div class=""><span style="font-size:13px" class="">Proposed naming convention #2 is:</span></div><div class=""><span style="font-size:13px" class=""><br class=""></span></div><div class=""><span style="font-size:13px" class="">(field_type, "<particle?>_<coordinate_system</span><span style="font-size:13px" class="">>_<position/velocity>_<coordinate>") </span><span style="font-size:13px" class="">e.g. ('all', 'particle_spherical_position_phi')</span><span style="font-size:13px" class=""><br class=""></span></div><div class=""><br class=""></div><div class="">Here are all of the relevant gas and particle fields each convention:</div><div class=""><br class=""></div><div class=""><b class="">Cartesian</b> (convention #1 & #2 are the same)</div><span class=""><div class=""><br class=""></div><div class="">('index', 'x')</div></span><div class="">('index', 'y')</div><div class="">('index', 'z')</div><span class=""><div class="">('gas', 'velocity_x')</div></span><div class="">('gas', 'velocity_y')</div><div class="">('gas', 'velocity_z')</div><div class=""><br class=""></div><div class="">('all', 'particle_position_x')</div><div class=""><div class="">('all', 'particle_position_y')</div></div><div class=""><div class="">('all', 'particle_position_z')</div></div><div class=""><div class="">('all', 'particle_velocity_x')</div></div><div class=""><div class="">('all', 'particle_velocity_y')</div></div><div class=""><div class="">('all', 'particle_velocity_z')</div></div><div class=""><br class=""></div><div class="">Convention #1 & #2 differ for the fields of cartesian position relative to the 'center' and 'normal' field parameters for the origin and z-vector:</div><div class=""><br class=""></div><div class="">#1 vs #2</div><div class="">('all', 'particle_position_relative_x') vs. ('all', 'particle_relative_position_x')</div><div class=""><div class="">('all', 'particle_position_relative_y') vs. ('all', 'particle_relative_position_y')</div></div><div class=""><div class="">('all', 'particle_position_relative_z') vs. ('all', 'particle_relative_position_z')</div></div><div class=""><div class="">('all', 'particle_velocity_relative_x') vs. ('all', 'particle_velocity_position_x')</div><div class="">('all', 'particle_velocity_relative_y') vs. ('all', 'particle_velocity_position_y')</div><div class="">('all', 'particle_velocity_relative_z') vs. ('all', 'particle_velocity_position_z')</div><div class=""><br class=""></div><div class=""><b class="">Spherical</b>:</div><div class="">#1 vs #2</div><div class=""><br class=""></div><div class="">('index', 'spherical_phi')</div><span class=""><div class="">('index', 'spherical_radius')</div></span><span class=""><div class="">('index', 'spherical_theta')</div></span><div class="">('gas', 'velocity_spherical_phi') vs ('gas', 'spherical_velocity_phi')</div><div class="">('gas', 'velocity_spherical_theta') vs ('gas', 'spherical_velocity_theta')</div><div class="">('gas', 'velocity_spherical_radius') vs ('gas', 'spherical_velocity_radius')</div><div class=""><br class=""></div><div class="">('all', 'particle_position_spherical_phi') vs ('all', 'particle_spherical_position_phi')</div><div class=""><div class=""><div class="">('all', 'particle_position_spherical_theta') vs ('all', 'particle_spherical_position_theta')</div></div></div></div><div class=""><div class="">('all', 'particle_position_spherical_radius') vs ('all', 'particle_spherical_position_radius')</div><div class=""><div class=""><div class="">('all', 'particle_velocity_spherical_phi') vs ('all', 'particle_spherical_velocity_phi')</div><div class="">('all', 'particle_velocity_spherical_theta') vs ('all', 'particle_spherical_velocity_theta')</div></div><div class=""><div class="">('all', 'particle_velocity_spherical_radius') vs ('all', 'particle_spherical_velocity_radius')</div><div class=""><br class=""></div><div class=""><b class="">Cylindrical</b>:</div><div class="">#1 vs #2</div><div class=""><br class=""></div><div class=""><div class="">('index', 'cylindrical_phi') </div><div class="">('index', 'cylindrical_radius')</div><div class="">('index', 'cylindrical_theta')</div><div class="">('gas', 'velocity_cylindrical_phi') vs ('gas', 'cylindrical_velocity_phi')</div><div class="">('gas', 'velocity_cylindrical_theta') vs ('gas', 'cylindrical_velocity_theta')</div><div class="">('gas', 'velocity_cylindrical_radius') vs ('gas', 'cylindrical_velocity_radius')</div></div><div class=""><br class=""></div><div class=""><div class=""><div class="">('all', 'particle_position_cylindrical_phi') vs ('all', 'particle_cylindrical_position_phi')</div><div class="">('all', 'particle_position_cylindrical_theta') vs ('all', 'particle_cylindrical_position_theta')</div></div><div class=""><div class="">('all', 'particle_position_cylindrical_radius') vs ('all', 'particle_cylindrical_position_radius')</div><div class=""><div class=""><div class="">('all', 'particle_velocity_cylindrical_phi') vs ('all', 'particle_cylindrical_velocity_phi')</div><div class="">('all', 'particle_velocity_cylindrical_theta') vs ('all', 'particle_cylindrical_velocity_theta')</div></div><div class="">('all', 'particle_velocity_cylindrical_radius') vs ('all', 'particle_cylindrical_velocity_radius')</div></div></div></div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><div class="">So what does the community think would be the best system here? #1 or #2? Either way it goes, I think this is a big improvement over the previous naming convention that had general inconsistencies.</div><div class=""><br class=""></div></div></div></div></div><div class="">Cameron</div><div class=""><br class=""></div><div class="gmail_extra"><br class=""><div class="gmail_quote"><div class=""><div class="">On Tue, Dec 23, 2014 at 11:01 AM, Nathan Goldbaum <span dir="ltr" class=""><<a href="mailto:nathan12343@gmail.com" target="_blank" class="">nathan12343@gmail.com</a>></span> wrote:<br class=""></div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class=""><div class=""><div dir="ltr" class="">Hi all,<div class=""><br class=""></div><div class="">I've just issued a pull request that bears some developer discussion.</div><div class=""><br class=""></div><div class="">Right now yt is a bit of a wild west in terms of the field naming convention for fields that reference a coordinate system. See for example, see issue 947:</div><div class=""><br class=""></div><div class=""><a href="https://bitbucket.org/yt_analysis/yt/issue/947/consistent-field-naming-for-spherical-and" target="_blank" class="">https://bitbucket.org/yt_analysis/yt/issue/947/consistent-field-naming-for-spherical-and</a></div><div class=""><br class=""></div><div class="">I'd like to propose a naming convention for fields that reference a coordinate system. Gas and particle fields should be of the form:</div><div class=""><br class=""></div><div class="">(field_type, "<particle?>_<vector_field_name>_<coordinate>")</div><div class=""><br class=""></div><div class="">while index fields for coordinates should be of the form:</div><div class=""><br class=""></div><div class="">("index", "<coordinate>")</div><div class=""><br class=""></div><div class="">This fits within our existing field naming convention for cartesian coordinates, e.g.:</div><div class=""><br class=""></div><div class="">("gas", "velocity_x")</div><div class="">(ptype, "particle_velocity_y")</div><div class=""><br class=""></div><div class="">as well as our convention for index coordinate fields, e.g.:</div><div class=""><br class=""></div><div class="">("index", "x")</div><div class="">("index", "spherical_theta")</div><div class=""><br class=""></div><div class="">This means that index fields do not need to explicitly reference themselves as positions. So we *won't* have field names like:</div><div class=""><br class=""></div><div class="">("index", "position_x")</div><div class=""><br class=""></div><div class="">I don't like the above construction because it's a bit redundant ("index" implies that we are talking about a position or something similar).</div><div class=""><br class=""></div><div class="">Some existing field names will need to be changed to fit this. In particular, some of the index fields will need to be renamed to be more verbose ("index", "spherical_r") becomes ("index", "spherical_radius") and (ptype, "particle_spherical_position_radius") becomes (ptype, "particle_position_spherical_radius").</div><div class=""><br class=""></div><div class="">Wherever an existing field name needs to change, I propose we mark the existing field name for deprecation, stub it out, and make it an alias for the field with the new field name. In a future release, we can then remove the deprecated fields.</div><div class=""><br class=""></div><div class="">I've implemented this for the particle fields (for the most part) in PR 1378:</div><div class=""><br class=""></div><div class=""><a href="https://bitbucket.org/yt_analysis/yt/pull-request/1378" target="_blank" class="">https://bitbucket.org/yt_analysis/yt/pull-request/1378</a><br class=""></div><div class=""><br class=""></div><div class="">I'm happy to update the field naming YTEP if this proposed field naming scheme gets approval in this thread.</div><div class=""><br class=""></div><div class="">What do you all think? Question, concerns?</div><span class=""><font color="#888888" class=""><div class=""><br class=""></div><div class="">-Nathan</div><div class=""><br class=""></div><div class=""><br class=""></div></font></span></div>
<br class=""></div></div><span class="">_______________________________________________<br class="">
yt-dev mailing list<br class="">
<a href="mailto:yt-dev@lists.spacepope.org" target="_blank" class="">yt-dev@lists.spacepope.org</a><br class="">
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank" class="">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br class="">
<br class=""></span></blockquote></div><span class=""><font color="#888888" class=""><br class=""><br clear="all" class=""><div class=""><br class=""></div>-- <br class=""><div class="">Cameron Hummels<div class="">Postdoctoral Researcher</div><div class="">Steward Observatory</div><div class="">University of Arizona</div><div class=""><a href="http://chummels.org/" target="_blank" class="">http://chummels.org</a></div></div>
</font></span></div></div>
<br class="">_______________________________________________<br class="">
yt-dev mailing list<br class="">
<a href="mailto:yt-dev@lists.spacepope.org" target="_blank" class="">yt-dev@lists.spacepope.org</a><br class="">
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank" class="">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br class="">
<br class=""></blockquote></div></div></div><br class=""></div></div>
<br class="">_______________________________________________<br class="">
yt-dev mailing list<br class="">
<a href="mailto:yt-dev@lists.spacepope.org" target="_blank" class="">yt-dev@lists.spacepope.org</a><br class="">
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank" class="">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br class="">
<br class=""></blockquote></div></div></div><br class=""></div></div>
<br class="">_______________________________________________<br class="">
yt-dev mailing list<br class="">
<a href="mailto:yt-dev@lists.spacepope.org" target="_blank" class="">yt-dev@lists.spacepope.org</a><br class="">
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank" class="">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br class="">
<br class=""></blockquote></div><br class=""></div>
______________________________<u class=""></u>_________________<br class="">
yt-dev mailing list<br class="">
<a href="mailto:yt-dev@lists.spacepope.org" target="_blank" class="">yt-dev@lists.spacepope.org</a><br class="">
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank" class="">http://lists.spacepope.org/<u class=""></u>listinfo.cgi/yt-dev-spacepope.<u class=""></u>org</a><br class="">
</blockquote></div>
</div></div><br class="">_______________________________________________<br class="">
yt-dev mailing list<br class="">
<a href="mailto:yt-dev@lists.spacepope.org" target="_blank" class="">yt-dev@lists.spacepope.org</a><br class="">
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank" class="">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br class="">
<br class=""></blockquote></div><br class=""></div>
</div></div><br class="">_______________________________________________<br class="">
yt-dev mailing list<br class="">
<a href="mailto:yt-dev@lists.spacepope.org" target="_blank" class="">yt-dev@lists.spacepope.org</a><br class="">
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank" class="">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br class="">
<br class=""></blockquote></div><br class=""></div>
</div></div><br class="">_______________________________________________<br class="">
yt-dev mailing list<br class="">
<a href="mailto:yt-dev@lists.spacepope.org" class="">yt-dev@lists.spacepope.org</a><br class="">
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank" class="">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br class="">
<br class=""></blockquote></div><br class=""></div>
_______________________________________________<br class="">yt-dev mailing list<br class=""><a href="mailto:yt-dev@lists.spacepope.org" class="">yt-dev@lists.spacepope.org</a><br class="">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org<br class=""></div></blockquote></div><br class=""></div></body></html>