<div dir="ltr">I like the idea of letting the user override the label as they see fit. There should be a good default that works for 90% of the cases, and an optional keyword argument to tweak things as needed. (I don't typically need projections, so I don't have an opinion on the defaults).</div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Jul 17, 2014 at 9:52 AM, j s oishi <span dir="ltr"><<a href="mailto:jsoishi@gmail.com" target="_blank">jsoishi@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<p dir="ltr">Hi Matt,</p>
<p dir="ltr">I am struggling to understand your objection. The unit is already changed in projection. Cameron's point is that the variable name is not changed, and without a qualifier such as integrated or projected, it does look like the user made a typo. Why would we want to put the burden on the user to correct such a common occurrence? I guess I don't understand your objection. Could you expand on why you are so skittish about changing the colorbar label? I am assuming there is a technical objection I don't know about.</p>
<p dir="ltr">Also, I think adding a title is not a good solution, since it creates a large distance between between "projection" and "density" (for example), but leaves no distance between "density" and "g/cm^2".</p>
<p dir="ltr">Furthermore, regarding Sam's objection regarding SZ and other unusual fields, I wonder if we should put the burden of manually entering the label on the least likely use case. I think, though I could be wrong, that the majority of Astro users are interested in density projections, in which case we should use "projection" by default. If we are striving to generalize beyond that, then I think "integrated" is the proper word.</p>
<span class="HOEnZb"><font color="#888888">
<p dir="ltr">J</p></font></span><div class="HOEnZb"><div class="h5">
<div style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Cameron,<br>
<br>
I've done a lot of thinking about this, and I'm of two minds.<br>
<br>
1) I do not think we should change the colorbar; we're displaying<br>
units there, and we should either let the person making the plot<br>
change the title of those units, or we should display what they are.<br>
2) We should allow the plots to indicate somehow what they are, rather<br>
than delegating that exclusively to the filename.<br>
<br>
Do you think it would suffice to add a title to the plots? That would<br>
not touch the "units" (which I am really skittish about modifying) but<br>
will still display the semantic information about the plot.<br>
<br>
-Matt<br>
<br>
On Tue, Jul 15, 2014 at 7:56 PM, Nathan Goldbaum <<a href="mailto:nathan12343@gmail.com" target="_blank">nathan12343@gmail.com</a>> wrote:<br>
><br>
><br>
><br>
> On Tue, Jul 15, 2014 at 5:47 PM, Cameron Hummels <<a href="mailto:chummels@gmail.com" target="_blank">chummels@gmail.com</a>> wrote:<br>
><br>
>><br>
>> after all, we have projected_units attached to the fields.<br>
><br>
><br>
> Nope, not after unitrefactor was merged in.<br>
><br>
>><br>
>><br>
>><br>
>> On Tue, Jul 15, 2014 at 5:45 PM, John ZuHone <<a href="mailto:jzuhone@gmail.com" target="_blank">jzuhone@gmail.com</a>> wrote:<br>
>>><br>
>>> This is probably a bad idea, but could we add a "projected_name" keyword<br>
>>> (or something similar) to the add_field function, which could be "Projected"<br>
>>> as the default but could be left as "" for things like SZY? It would only be<br>
>>> applied if there isn't a weight field.<br>
>>><br>
>>> I suspect folks feel that add_field already has too many keyword<br>
>>> parameters, but I just wanted to throw it out there.<br>
>>><br>
>>> Sent from John ZuHone's iPad<br>
>>><br>
>>> On Jul 15, 2014, at 8:39 PM, Cameron Hummels <<a href="mailto:chummels@gmail.com" target="_blank">chummels@gmail.com</a>> wrote:<br>
>>><br>
>>> Sam,<br>
>>><br>
>>> What would you think if we changed the "Projected" prepend to<br>
>>> "Integrated"? That would still apply well for "Integrated Density" as well<br>
>>> as "Integrated SZY", right?<br>
>>><br>
>>> I'm just very much against the default of having "Density (g/cm^2)" show<br>
>>> up on projection plots (using the 'integrated' type), because this is<br>
>>> misleading and it just makes it look like you made a mistake when your units<br>
>>> don't match your field. As Matt suggests, we could have the title set to<br>
>>> "Projection" for projections by default which is better than the current<br>
>>> settings IMO, but it seems less clean than changing the colorbar label.<br>
>>><br>
>>> Anyone else have any thoughts about this?<br>
>>><br>
>>> Cameron<br>
>>> On Tue, Jul 15, 2014 at 3:50 PM, Sam Skillman <<a href="mailto:samskillman@gmail.com" target="_blank">samskillman@gmail.com</a>><br>
>>> wrote:<br>
>>>><br>
>>>> Hi Cameron,hing<br>
>>>><br>
>>>> While it would be nice if there was a simple default that would work for<br>
>>>> all types of projections and fields, I think I'm also a -0 on this because<br>
>>>> of weird fields like the SZY, where it only makes sense as an integrated<br>
>>>> field, and Projected SZY isn't a term that is used. I think that simply<br>
>>>> allowing others to modify the colorbar name is the more sustainable way in<br>
>>>> terms of handling all of the options for integration type as well. I could<br>
>>>> be convinced otherwise, but I think having the units for things like density<br>
>>>> show up as g/cm^2 vs g/cm^3 should be enough for the time being.<br>
>>>><br>
>>>> Sam<br>
>>>><br>
>>>><br>
>>>><br>
>>>><br>
>>>> On Tue, Jul 15, 2014 at 7:22 AM, Matthew Turk <<a href="mailto:matthewturk@gmail.com" target="_blank">matthewturk@gmail.com</a>><br>
>>>> wrote:<br>
>>>>><br>
>>>>> Hi Cameron,<br>
>>>>><br>
>>>>> I'm -0 on this, but mainly because I don't really like changing it to<br>
>>>>> have that information as part of the colorbar, rather than the title<br>
>>>>> for instance.<br>
>>>>><br>
>>>>> -Matt<br>
>>>>><br>
>>>>> On Tue, Jul 15, 2014 at 12:06 AM, Cameron Hummels <<a href="mailto:chummels@gmail.com" target="_blank">chummels@gmail.com</a>><br>
>>>>> wrote:<br>
>>>>> > Oh, I almost forgot to show examples:<br>
>>>>> ><br>
>>>>> > current behavior of a non-weighted density projection:<br>
>>>>> > <a href="http://i.imgur.com/vBSRRLq.png" target="_blank">http://i.imgur.com/vBSRRLq.png</a><br>
>>>>> ><br>
>>>>> > proposed behavior of a non-weighted density projection:<br>
>>>>> > <a href="http://i.imgur.com/UP6f5Nh.png" target="_blank">http://i.imgur.com/UP6f5Nh.png</a><br>
>>>>> ><br>
>>>>> > although i like the idea that Nathan has about having "column<br>
>>>>> > density" for<br>
>>>>> > projected density plots.<br>
>>>>> ><br>
>>>>> ><br>
>>>>> > On Mon, Jul 14, 2014 at 9:41 PM, Nathan Goldbaum<br>
>>>>> > <<a href="mailto:nathan12343@gmail.com" target="_blank">nathan12343@gmail.com</a>><br>
>>>>> > wrote:<br>
>>>>> >><br>
>>>>> >><br>
>>>>> >><br>
>>>>> >><br>
>>>>> >> On Mon, Jul 14, 2014 at 9:35 PM, Cameron Hummels<br>
>>>>> >> <<a href="mailto:chummels@gmail.com" target="_blank">chummels@gmail.com</a>><br>
>>>>> >> wrote:<br>
>>>>> >>><br>
>>>>> >>> Hey everyone,<br>
>>>>> >>><br>
>>>>> >>> I've created a pull request which changes the defaults of the<br>
>>>>> >>> ProjectionPlot and OffAxisProjectionPlot, although I'm looking for<br>
>>>>> >>> feedback<br>
>>>>> >>> from the community.<br>
>>>>> >>><br>
>>>>> >>> Right now, when you create a projection, say for "Density", it<br>
>>>>> >>> labels the<br>
>>>>> >>> colorbar with "Density" and then gives its projected units (instead<br>
>>>>> >>> of<br>
>>>>> >>> g/cm^3, it gives g/cm^2). My PR is simply to change the default<br>
>>>>> >>> label to be<br>
>>>>> >>> "Projected <field>" in this case "Projected Density (g/cm^2)".<br>
>>>>> >><br>
>>>>> >><br>
>>>>> >> +1. I also sort of like the idea of special-casing - in particular<br>
>>>>> >> for<br>
>>>>> >> density, which I think should show up as "Column Density".<br>
>>>>> >><br>
>>>>> >>><br>
>>>>> >>> It will do this in the case of non-weighted projections.<br>
>>>>> >><br>
>>>>> >><br>
>>>>> >> Also only when proj_stype = "integrate".<br>
>>>>> >><br>
>>>>> >>><br>
>>>>> >>> I think this is the expected behavior and more accurate than the<br>
>>>>> >>> former<br>
>>>>> >>> behavior, but I'm open to discussion from the rest of the dev<br>
>>>>> >>> community.<br>
>>>>> >>><br>
>>>>> >>> In addition, it might be worthwhile to change the defaults on<br>
>>>>> >>> weighted-projections (e.g. density-weighted temperature<br>
>>>>> >>> projection), to give<br>
>>>>> >>> it and appropriate label as well, but I'm less convinced of this<br>
>>>>> >>> change.<br>
>>>>> >>> Perhaps something like "<weight_field>-Weighted <field> (units)" ?<br>
>>>>> >><br>
>>>>> >><br>
>>>>> >> I'm not sure about this. Whatever we decide on, it should hopefully<br>
>>>>> >> be<br>
>>>>> >> compact.<br>
>>>>> >><br>
>>>>> >>><br>
>>>>> >>><br>
>>>>> >>> There is also a PR awaiting approval by John Regan that deals with<br>
>>>>> >>> this<br>
>>>>> >>> behavior which will allow users to easily specify whatever label<br>
>>>>> >>> they want<br>
>>>>> >>> for the colorbar, but I thought having a sensible default was<br>
>>>>> >>> appropriate as<br>
>>>>> >>> well.<br>
>>>>> >>><br>
>>>>> >>> Anyway, what do people think about these potential changes?<br>
>>>>> >>><br>
>>>>> >>> Cameron<br>
>>>>> >>><br>
>>>>> >>><br>
>>>>> >>> --<br>
>>>>> >>> Cameron Hummels<br>
>>>>> >>> Postdoctoral Researcher<br>
>>>>> >>> Steward Observatory<br>
>>>>> >>> University of Arizona<br>
>>>>> >>> <a href="http://chummels.org" target="_blank">http://chummels.org</a><br>
>>>>> >>><br>
>>>>> >>> _______________________________________________<br>
>>>>> >>> yt-dev mailing list<br>
>>>>> >>> <a href="mailto:yt-dev@lists.spacepope.org" target="_blank">yt-dev@lists.spacepope.org</a><br>
>>>>> >>> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
>>>>> >>><br>
>>>>> >><br>
>>>>> >><br>
>>>>> >> _______________________________________________<br>
>>>>> >> yt-dev mailing list<br>
>>>>> >> <a href="mailto:yt-dev@lists.spacepope.org" target="_blank">yt-dev@lists.spacepope.org</a><br>
>>>>> >> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
>>>>> >><br>
>>>>> ><br>
>>>>> ><br>
>>>>> ><br>
>>>>> > --<br>
>>>>> > Cameron Hummels<br>
>>>>> > Postdoctoral Researcher<br>
>>>>> > Steward Observatory<br>
>>>>> > University of Arizona<br>
>>>>> > <a href="http://chummels.org" target="_blank">http://chummels.org</a><br>
>>>>> ><br>
>>>>> > _______________________________________________<br>
>>>>> > yt-dev mailing list<br>
>>>>> > <a href="mailto:yt-dev@lists.spacepope.org" target="_blank">yt-dev@lists.spacepope.org</a><br>
>>>>> > <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
>>>>> ><br>
>>>>> _______________________________________________<br>
>>>>> yt-dev mailing list<br>
>>>>> <a href="mailto:yt-dev@lists.spacepope.org" target="_blank">yt-dev@lists.spacepope.org</a><br>
>>>>> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
>>>><br>
>>>><br>
>>>><br>
>>>> _______________________________________________<br>
>>>> yt-dev mailing list<br>
>>>> <a href="mailto:yt-dev@lists.spacepope.org" target="_blank">yt-dev@lists.spacepope.org</a><br>
>>>> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
>>>><br>
>>><br>
>>><br>
>>><br>
>>> --<br>
>>> Cameron Hummels<br>
>>> Postdoctoral Researcher<br>
>>> Steward Observatory<br>
>>> University of Arizona<br>
>>> <a href="http://chummels.org" target="_blank">http://chummels.org</a><br>
>>><br>
>>> _______________________________________________<br>
>>> yt-dev mailing list<br>
>>> <a href="mailto:yt-dev@lists.spacepope.org" target="_blank">yt-dev@lists.spacepope.org</a><br>
>>> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
>>><br>
>>><br>
>>> _______________________________________________<br>
>>> yt-dev mailing list<br>
>>> <a href="mailto:yt-dev@lists.spacepope.org" target="_blank">yt-dev@lists.spacepope.org</a><br>
>>> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
>>><br>
>><br>
>><br>
>><br>
>> --<br>
>> Cameron Hummels<br>
>> Postdoctoral Researcher<br>
>> Steward Observatory<br>
>> University of Arizona<br>
>> <a href="http://chummels.org" target="_blank">http://chummels.org</a><br>
>><br>
>> _______________________________________________<br>
>> yt-dev mailing list<br>
>> <a href="mailto:yt-dev@lists.spacepope.org" target="_blank">yt-dev@lists.spacepope.org</a><br>
>> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
>><br>
><br>
><br>
> _______________________________________________<br>
> yt-dev mailing list<br>
> <a href="mailto:yt-dev@lists.spacepope.org" target="_blank">yt-dev@lists.spacepope.org</a><br>
> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
><br>
_______________________________________________<br>
yt-dev mailing list<br>
<a href="mailto:yt-dev@lists.spacepope.org" target="_blank">yt-dev@lists.spacepope.org</a><br>
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
</div>
</div></div><br>_______________________________________________<br>
yt-dev mailing list<br>
<a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Michael Zingale</div><div>Associate Professor</div><div><br></div><div>Dept. of Physics & Astronomy • Stony Brook University • Stony Brook, NY 11794-3800</div>
<div><i>phone</i>: 631-632-8225</div><div><i>e-mail</i>: <a href="mailto:Michael.Zingale@stonybrook.edu" target="_blank">Michael.Zingale@stonybrook.edu</a></div><div><i>web</i>: <a href="http://www.astro.sunysb.edu/mzingale" target="_blank">http://www.astro.sunysb.edu/mzingale</a></div>
</div>