<div dir="ltr">+1 to John's implementation. In the interim, tipsy can then still be loaded explicitly.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Apr 11, 2014 at 10:13 AM, John ZuHone <span dir="ltr"><<a href="mailto:jzuhone@gmail.com" target="_blank">jzuhone@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Sorry, being a bit more descriptive... by that I mean:<div><br></div><div>@classmethod</div>
<div>def _is_valid(self, *args, **kwargs):</div><div><span style="white-space:pre-wrap"> </span>return False</div><div><span style="white-space:pre-wrap"> </span>...</div><div><br></div><div>Which is a bit hacky, but the least invasive.</div>
<div><div class="h5"><div><br><div><div>On Apr 11, 2014, at 1:07 PM, John ZuHone <<a href="mailto:jzuhone@gmail.com" target="_blank">jzuhone@gmail.com</a>> wrote:</div><br><blockquote type="cite"><div style="word-wrap:break-word">
+1, except it seems like the easiest thing to do is to just make sure that Tipsy's _is_valid always returns False for now.<div><br><div><div>On Apr 11, 2014, at 12:41 PM, Nathan Goldbaum <<a href="mailto:nathan12343@gmail.com" target="_blank">nathan12343@gmail.com</a>> wrote:</div>
<br><blockquote type="cite">Hi all,<div><br></div><div>While Ben works on his fix, would anyone object to temporarily reverting the merged pull request that triggered this behavior?</div><div><br></div><div>I worry about FLASH users who do not read yt-dev. I guess it *is* the bleeding edge, experimental version so bugs should be expected but still,<span></span> reverting seems like an easy temporary fix that takes some pressure off Ben to quickly develop a true fix to the underlying issue.</div>
<div><br></div><div>Nathan</div><div><br>On Thursday, April 10, 2014, B.W. Keller <<a href="mailto:kellerbw@mcmaster.ca" target="_blank">kellerbw@mcmaster.ca</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Good idea Mike! I'll do that too.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Apr 10, 2014 at 7:39 PM, Mike Warren <span dir="ltr"><<a>mswarren@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">You could detect that it is not a tipsy file quickly, by using the<br>
constraint in the header that nbodies=nsph+ndark+nstar and ndim is<br>
presumably 1,2 or 3.<br>
<br>
struct tipsy_dump {<br>
double time;<br>
int nbodies;<br>
int ndim;<br>
int nsph;<br>
int ndark;<br>
int nstar;<br>
<div>};<br>
<br>
<br>
On Thu, Apr 10, 2014 at 5:32 PM, B.W. Keller <<a>kellerbw@mcmaster.ca</a>> wrote:<br>
</div><div>> Oh my. Sorry that I have introduced this, unfortunately there is no way to<br>
> detect tipsy files other than actually reading the entire file from disk.<br>
> Perhaps the way to fix this would be to drop the priority of tipsy datasets<br>
> to the bottom, so that a valid FLASH dataset will be detected prior to the<br>
> Tipsy check?<br>
><br>
><br>
> On Thu, Apr 10, 2014 at 7:15 PM, Nathan Goldbaum <<a>nathan12343@gmail.com</a>><br>
> wrote:<br>
>><br>
>> Hi all,<br>
>><br>
>> We just had a bug report from Aaron Smith at UT Austin. The symptom is<br>
>> that the "load" comman was taking 30 seconds to complete on his FLASH<br>
>> dataset, which should never happen for FLASH.<br>
>><br>
>> After asking him to profile the code, he produced the following profile:<br>
>><br>
>> <a href="http://ngoldbaum.net/yt-load/" target="_blank">http://ngoldbaum.net/yt-load/</a><br>
>><br>
>> It seems that the recent changes to the Tipsy frontend which allow it to<br>
>> autodetect binary outputs have made it so in some cases non-tipsy data is<br>
>> loaded off disk.<br>
>><br>
>> I'm not sure about the best way to handle this, which is why I'm writing<br>
>> to the list rather than issuing a PR.<br>
>><br>
>> -Nathan<br>
>><br>
><br>
><br>
</div><div>> _______________________________________________<br>
> yt-dev mailing list<br>
> <a>yt-dev@lists.spacepope.org</a><br>
> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
><br>
_______________________________________________<br>
yt-dev mailing list<br>
<a>yt-dev@lists.spacepope.org</a><br>
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
</div></blockquote></div><br></div>
</blockquote></div>
_______________________________________________<br>yt-dev mailing list<br><a href="mailto:yt-dev@lists.spacepope.org" target="_blank">yt-dev@lists.spacepope.org</a><br><a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
</blockquote></div><br></div></div></blockquote></div><br></div></div></div></div><br>_______________________________________________<br>
yt-dev mailing list<br>
<a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
<br></blockquote></div><br></div>