<div dir="ltr">I agree that having this PR merged into the main code branch will ease some of the difficulties that have arisen in PRs to PRs in individual user's repositories. That's why I'm +1 on merging it, but I guess I am -1 on merging it immediately since there are outstanding issues.<div>
<br></div><div>But I'm confused by what's being said here. Yesterday, Matt said documentation already existed for all of the units stuff in the unit refactor, but Nathan is saying he'll write it this weekend. I thought the only thing left to be documented was the SPH smoothing stuff, which Matt said he wouldn't do until March. Is there more to document about the unit refactor and how it works?</div>
<div><br></div><div>My main concern is to avoid that which has happened in the past--that code gets introduced and the authors say they'll introduce documentation on it later, which may get postponed for a long period or even indefinitely. As John rightly points out, this PR changes a great deal of the underlying structure in yt, and it's going to be confusing for both users and developers accustomed to the old way. I want to make sure that those of us who were not actively involved in the development of the unit refactor can figure out what is going on, so that we can continue to contribute to the code. Documentation enables this.</div>
<div><br></div><div>Lastly, if the docs cannot even be built in the PR, then I would strongly recommend waiting to accept until they can. Now that the yt-docs repository is deprecated, the yt-3.0 branch is the only location where the current state of the documentation exists. If we cannot even build it, then we lack up to date docs, and no one will contribute docs on other new featuers because they cannot compile their documentation.</div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Feb 6, 2014 at 12:54 PM, Nathan Goldbaum <span dir="ltr"><<a href="mailto:nathan12343@gmail.com" target="_blank">nathan12343@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">On Thu, Feb 6, 2014 at 11:47 AM, John ZuHone <<a href="mailto:jzuhone@gmail.com">jzuhone@gmail.com</a>> wrote:<br>
> Thinking about this some more...<br>
><br>
> The unit and field refactoring are very big changes that effect nearly every part of the codebase. Since a lot of our documentation relies on notebooks, it would seem to me that writing these would be a lot easier if we integrated the major parts of this release together first. That way issues that crop up and unexpected bugs can be addressed immediately, as opposed to writing docs and then finding out later that they need to be changed after the big merge is made.<br>
><br>
<br>
</div>We've been trying to merge with mainline dev as much as possible. It<br>
doesn't happen immediately because it adds cognitive overhead to<br>
dealing with development, so it ends up happening as a PR every couple<br>
of weeks.<br>
<br>
Merging into the main repo will help ease the burden of periodic<br>
merging and fixing bugs exposed by the merge.<br>
<br>
I think Matt was actually trying to get a docs build to run last<br>
night. I'm not sure how much work it would be to get the docs into a<br>
state where they can be built in yt-3.0, even if the narrative docs<br>
have not been updated to be consistent with the codebase yet.<br>
<div class="HOEnZb"><div class="h5"><br>
> I suppose the response to that is that we ought to merge from yt-dev into the units fork, but this seems to the six of one vs half-dozen of the other.<br>
><br>
> John ZuHone<br>
> Laboratory for High-Energy Astrophysics<br>
> NASA/Goddard Space Flight Center<br>
> 8800 Greenbelt Rd., Mail Code 662<br>
> Greenbelt, MD 20771<br>
> (w) <a href="tel:301-286-2531" value="+13012862531">301-286-2531</a><br>
> (m) <a href="tel:781-708-5004" value="+17817085004">781-708-5004</a><br>
> <a href="mailto:john.zuhone@nasa.gov">john.zuhone@nasa.gov</a><br>
> <a href="mailto:jzuhone@gmail.com">jzuhone@gmail.com</a><br>
><br>
>> On Feb 6, 2014, at 2:30 PM, Nathan Goldbaum <<a href="mailto:nathan12343@gmail.com">nathan12343@gmail.com</a>> wrote:<br>
>><br>
>> I can prepare docs for units this weekend.<br>
>><br>
>> Documentation for SPH smoothing and the new field system will depend<br>
>> on Matt, who in a previous e-mail said he wouldn't have time to work<br>
>> seriously on docs until March. I don't think "wait until March" makes<br>
>> sense here...<br>
>><br>
>> -Nathan<br>
>><br>
>>> On Thu, Feb 6, 2014 at 11:27 AM, Cameron Hummels <<a href="mailto:chummels@gmail.com">chummels@gmail.com</a>> wrote:<br>
>>> I'm +1 on merging into the 3.0 dev branch, but only after documentation<br>
>>> exists for the features that are being introduced by this PR. I know this<br>
>>> isn't what people want to hear, but I think it will be much easier to<br>
>>> support if people other than the main authors know how it works and how to<br>
>>> use it.<br>
>>><br>
>>><br>
>>>> On Thu, Feb 6, 2014 at 11:52 AM, John ZuHone <<a href="mailto:jzuhone@gmail.com">jzuhone@gmail.com</a>> wrote:<br>
>>>><br>
>>>> +1 on merging into the 3.0 dev branch.<br>
>>>><br>
>>>> -1 on separate branch.<br>
>>>><br>
>>>> On Feb 6, 2014, at 1:45 PM, Sam Skillman <<a href="mailto:samskillman@gmail.com">samskillman@gmail.com</a>> wrote:<br>
>>>><br>
>>>> I am a +1 on this for all of the reasons you've stated. I would be much<br>
>>>> more likely to contribute bugfixes/enhancements/docs as well as test/report<br>
>>>> issues if it was on the main branch, even if it means the 3.0 branch is less<br>
>>>> "stable" than it is currently. I'd suggest we tag the last non-unitrefactor<br>
>>>> commit so that 3.0 users can have a easy way to revert to non-unitful yt if<br>
>>>> they way, but besides that I think we should go for it.<br>
>>>><br>
>>>> I'm -1 on a separate stable/dev branch for 3.0.<br>
>>>><br>
>>>> Sam<br>
>>>><br>
>>>><br>
>>>> On Thu, Feb 6, 2014 at 10:34 AM, Nathan Goldbaum <<a href="mailto:nathan12343@gmail.com">nathan12343@gmail.com</a>><br>
>>>> wrote:<br>
>>>>><br>
>>>>> Hi all,<br>
>>>>><br>
>>>>> Over the past month or so development has been proceeding apace on the<br>
>>>>> unit refactor in Matt's fork of yt. We did this because Matt initially<br>
>>>>> opened the unitrefactor PR and at that time it was not ready for<br>
>>>>> merging.<br>
>>>>><br>
>>>>> However, thanks to everyone's hard work, unitrefactor is getting more<br>
>>>>> and more stable and I think it's time to think about merging it into<br>
>>>>> the main repo, even if there are open issues or some remaining bits of<br>
>>>>> functionality that haven't been updated yet.<br>
>>>>><br>
>>>>> With tons of development going on in Matt's fork, I think we're<br>
>>>>> possibly leaving out people who aren't watching his repo.<br>
>>>>> Additionally, since Matt is the only one who can merge pull requests<br>
>>>>> into his repo, we need to use a lot more of his attention to keep work<br>
>>>>> moving forward.<br>
>>>>><br>
>>>>> It's true that there is some functionality that still needs to be<br>
>>>>> ported and bugs that need to be fixed. Matt's trello board summarizes<br>
>>>>> most of the issues (BTW, I see a couple missing issues, would you be<br>
>>>>> open to adding more users to it?):<br>
>>>>><br>
>>>>> <a href="https://trello.com/b/yv7o0dTp/unit-refactor" target="_blank">https://trello.com/b/yv7o0dTp/unit-refactor</a><br>
>>>>><br>
>>>>> One option would be to open a new named branch in the main repo, while<br>
>>>>> still keeping the current 3.0 tip in a 'stable' state. I'm less<br>
>>>>> inclined to go this route because I think unitrefactor is such a big<br>
>>>>> improvement over the current codebase, since many new features have<br>
>>>>> snuck in besides just adding units.<br>
>>>>><br>
>>>>> Another concern is that there aren't any docs yet. That's definitely<br>
>>>>> true, but there aren't any docs for the current 3.0 tip either. In<br>
>>>>> fact, now that there are a set of docs bundled in the repo in the<br>
>>>>> unitrefactor bookmark, merging should improve the documentation effort<br>
>>>>> for 3.0 going forward by making it more straightforward to enforce a<br>
>>>>> rule that things need to be documented before they get merged.<br>
>>>>><br>
>>>>> What do you all think?<br>
>>>>><br>
>>>>> -Nathan<br>
>>>>> _______________________________________________<br>
>>>>> yt-dev mailing list<br>
>>>>> <a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
>>>>> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
>>>><br>
>>>><br>
>>>> _______________________________________________<br>
>>>> yt-dev mailing list<br>
>>>> <a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
>>>> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
>>>><br>
>>>><br>
>>>><br>
>>>> _______________________________________________<br>
>>>> yt-dev mailing list<br>
>>>> <a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
>>>> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
>>><br>
>>><br>
>>><br>
>>> --<br>
>>> Cameron Hummels<br>
>>> Postdoctoral Researcher<br>
>>> Steward Observatory<br>
>>> University of Arizona<br>
>>> <a href="http://chummels.org" target="_blank">http://chummels.org</a><br>
>>><br>
>>> _______________________________________________<br>
>>> yt-dev mailing list<br>
>>> <a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
>>> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
>> _______________________________________________<br>
>> yt-dev mailing list<br>
>> <a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
>> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
> _______________________________________________<br>
> yt-dev mailing list<br>
> <a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
_______________________________________________<br>
yt-dev mailing list<br>
<a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Cameron Hummels<div>Postdoctoral Researcher</div><div>Steward Observatory</div><div>University of Arizona</div><div><a href="http://chummels.org" target="_blank">http://chummels.org</a></div>
</div>