<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>My apologies--Nathan has informed me that test definitely came in unitrefactor. Not sure how I did that, because I don't remember merging it in. However, my mercurial skills are still slightly less than kung-fu.</div><div><br></div><div>Anyway, happy new year!<br><br>John ZuHone<div>Laboratory for High-Energy Astrophysics<br><div>NASA/Goddard Space Flight Center</div><div>8800 Greenbelt Rd., Mail Code 662</div><div>Greenbelt, MD 20771</div><div>(w) 301-286-2531</div><div>(m) 781-708-5004</div></div><div><a href="mailto:john.zuhone@nasa.gov">john.zuhone@nasa.gov</a></div><div><a href="mailto:jzuhone@gmail.com">jzuhone@gmail.com</a></div></div><div><br>On Dec 31, 2013, at 7:51 PM, Nathan Goldbaum <<a href="mailto:nathan12343@gmail.com">nathan12343@gmail.com</a>> wrote:<br><br></div><blockquote type="cite"><div><div dir="ltr">Hi John,<div><br></div><div>If you take a look at Matt's fork, you'll see that I recently updated that unit test to compare to 12 decimal places instead of requiring bitwise identicality. See this PR: <a href="https://bitbucket.org/MatthewTurk/yt/pull-request/6/unit-consistency-enzo-cosmology-units/diff">https://bitbucket.org/MatthewTurk/yt/pull-request/6/unit-consistency-enzo-cosmology-units/diff</a></div>
<div><br></div><div>I think if you merge with Matt (specifically, the unitrefactor bookmark on <a href="https://bitbucket.org/MatthewTurk/yt">https://bitbucket.org/MatthewTurk/yt</a>) that issue should go away. Not sure if new issues will crop up.</div>
<div><br></div><div>-Nathan</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Dec 31, 2013 at 3:45 PM, John Zuhone <span dir="ltr"><<a href="mailto:jzuhone@gmail.com" target="_blank">jzuhone@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi all,<br>
<br>
Good news on the Windows/yt front. I'm happy to announce that as of<br>
right now only one unit test is failing. The failure is subtle, but I<br>
thought I would run it by you all to see what we should do about it.<br>
<br>
The failure in question is a comparison test in<br>
yt/utilities/tests/test_units.py, in "test_power":<br>
<br>
assert u2.cgs_value == (pc_cgs**2 * mK_cgs**4)**2<br>
<br>
basically, the unit cgs_value is exactly the combination of these<br>
factors, so even though they are floats, one would expect that the<br>
equality should hold, and on our other platforms it does. However, on<br>
Windows, the comparison is failing on the last digit, with a relative<br>
difference of ~4e-16 between the two values. So, while I'm not<br>
inclined to be very concerned about it, I'm curious to see what you<br>
guys think about how it should be handled.<br>
<br>
Happy New Year!<br>
<br>
John Z<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
John ZuHone<br>
<br>
Postdoctoral Researcher<br>
NASA/Goddard Space Flight Center<br>
<br>
<a href="mailto:jzuhone@gmail.com">jzuhone@gmail.com</a><br>
<a href="mailto:john.zuhone@nasa.gov">john.zuhone@nasa.gov</a><br>
_______________________________________________<br>
yt-dev mailing list<br>
<a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
</font></span></blockquote></div><br></div>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>yt-dev mailing list</span><br><span><a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a></span><br><span><a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a></span><br></div></blockquote></body></html>