<p dir="ltr">Ah, I think I see the issue.</p>
<p dir="ltr">Temperature is defined for capital T, and the same for Pressure. So pressure isn't being converted because we changed the field names. I'll fix this in my PR.</p>
<div class="gmail_quote">On Dec 2, 2013 5:49 PM, "Sam Geen" <<a href="mailto:samgeen@astro.ox.ac.uk">samgeen@astro.ox.ac.uk</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Downloading now; will take 20 mins or so on my crappy internet, if I haven't already gone to bed...<br>
<br>
Note also that the unit name (i.e. K) is missing; the same is true for pressure. The image for Density looks fine, by comparison. So it's possible it's not being converted somehow.<br>
<br>
On 02/12/13 23:40, Matthew Turk wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Sam,<br>
<br>
On Mon, Dec 2, 2013 at 5:37 PM, Sam Geen <<a href="mailto:samgeen@astro.ox.ac.uk" target="_blank">samgeen@astro.ox.ac.uk</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I noticed that an old version of Ramses I had didn't include mu, so I'm not<br>
sure when that crept in, but it's explicitly stated in the current<br>
amr/units.f90 file. Again, Romain may be able to help answer this<br>
authoritatively.<br>
<br>
In any case, I can check the version you upload against my snapshots; in my<br>
latest test the pressure and temperature units didn't work* (although the<br>
images looked fine), so if you happen to fix that then great!<br>
<br>
* <a href="http://i.imgur.com/mcGyuJD.png" target="_blank">http://i.imgur.com/mcGyuJD.png</a><br>
</blockquote>
These units look okay to me. 10^23 K sounds about right for a 100 pc<br>
box of fluid.<br>
<br>
(Kidding.)<br>
<br>
Can you check the output_00080 dataset here:<br>
<a href="http://yt-project.org/data/" target="_blank">http://yt-project.org/data/</a> and see if it matches to your<br>
expectations?<br>
<br>
-Matt<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
On 02/12/13 23:28, Matthew Turk wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Sam,<br>
<br>
On Mon, Dec 2, 2013 at 5:24 PM, Sam Geen <<a href="mailto:samgeen@astro.ox.ac.uk" target="_blank">samgeen@astro.ox.ac.uk</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Matt,<br>
<br>
I believe it's absolute metallicity (i.e. 0.02 = fiducial solar, 0.0 =<br>
primordial). If you're paranoid, you could check with Romain; I'll open<br>
up<br>
some outputs in the morning and confirm this.<br>
<br>
BTW, I didn't get a chance to hunt down the pressure/temperature units<br>
problem today, but if you take a look then be aware that temperature in<br>
Ramses is returned (in the version I have, anyway) as T/mu, i.e. you need<br>
to<br>
multiply by the mean gas particle mass to get temperature in Kelvin.<br>
Normally for a given hydrogen mass fraction this is just X + 4*Y + (?) Z<br>
(I<br>
think! it's late here, so worth checking...), but for radiative transfer<br>
runs you need to be a bit careful since you also have electrons - we can<br>
look at this when the RT module output format is implemented, though.<br>
</blockquote>
Ah, thank you. That makes sense, and I'll apply these conversions for<br>
metallicity.<br>
<br>
For pressure, currently what we are doing is:<br>
<br>
def _Temperature(field, data):<br>
rv = data["Pressure"]/data["<u></u>Density"]<br>
rv *= mass_hydrogen_cgs/boltzmann_<u></u>constant_cgs<br>
return rv<br>
add_field("Temperature", function=_Temperature, units=r"\rm{K}")<br>
<br>
So it looks like that will need to be updated. I think this was set<br>
up on-demand from someone, and they compared it against their previous<br>
results, so I'm not sure where the discrepancy comes in.<br>
<br>
-Matt<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Cheers,<br>
<br>
Sam<br>
<br>
<br>
On 02/12/13 22:02, Matthew Turk wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Sam,<br>
<br>
What're the metallicity units for RAMSES? Nathan and I are updating<br>
for the yt-3.0 unit refactor and we're trying to get the RAMSES<br>
conversion done today.<br>
<br>
-Matt<br>
<br>
On Wed, Nov 27, 2013 at 12:23 PM, Sam Geen <<a href="mailto:samgeen@astro.ox.ac.uk" target="_blank">samgeen@astro.ox.ac.uk</a>><br>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
<br>
I intend to try to fiddle with the RAMSES frontend when I have<br>
time/need,<br>
and thought it would be good to collate a list of tasks that need to be<br>
completed so we have a consensus on what needs to be fixed. Feel free<br>
to<br>
suggest things or tell me that they're already implemented if I missed<br>
them:<br>
<br>
1) Add support for RT and ATON files, which are now part of the default<br>
RAMSES (I assume from the code that the cooling and grav files are<br>
already<br>
read)<br>
2) Via 1), it might be nice to refactor the RAMSESDomainFile class a<br>
bit<br>
to<br>
provide a more generic Ramses file reading routine/class, since the<br>
formats<br>
of the files are fairly similar and in doing 1) we might get some<br>
copy-paste<br>
bloat.<br>
3) Allow for RAMSES runs that only contain AMR & particles (i.e. pure<br>
N-body<br>
runs with no hydro)<br>
4) Refactor the inputs to fit YT default field names (for MHD, RT and<br>
ATON).<br>
5) Allow YT to interpret non-cosmological simulations in RAMSES, or if<br>
it<br>
already does, remove the warning that says this.<br>
6) Romain Teyssier suggested allowing users to specify their own<br>
default<br>
field names for user-modified versions of RAMSES. I don't know if YT<br>
caches<br>
data that would allow this, but I thought I'd punt the suggestion<br>
along.<br>
Another option could be to allow users to expose the RAMSES namelist<br>
files<br>
to YT (i.e. the parameter files for starting up a run) - these contain<br>
a<br>
lot<br>
more information on the physics included, etc. I'd put this on a low<br>
priority unless someone thinks of something clever that solves this<br>
cleanly.<br>
7) It could be worthwhile to implement read-on-demand if it's not<br>
already<br>
-<br>
sometimes the users won't query the ATON/RT/hydro/particle file or<br>
certain<br>
fluid fields in each file and so we wouldn't need to read those files<br>
in<br>
that case. This could be folded into 2).<br>
<br>
Cheers,<br>
<br>
Sam<br>
______________________________<u></u>_________________<br>
yt-dev mailing list<br>
<a href="mailto:yt-dev@lists.spacepope.org" target="_blank">yt-dev@lists.spacepope.org</a><br>
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/<u></u>listinfo.cgi/yt-dev-spacepope.<u></u>org</a><br>
</blockquote>
______________________________<u></u>_________________<br>
yt-dev mailing list<br>
<a href="mailto:yt-dev@lists.spacepope.org" target="_blank">yt-dev@lists.spacepope.org</a><br>
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/<u></u>listinfo.cgi/yt-dev-spacepope.<u></u>org</a><br>
</blockquote>
<br>
______________________________<u></u>_________________<br>
yt-dev mailing list<br>
<a href="mailto:yt-dev@lists.spacepope.org" target="_blank">yt-dev@lists.spacepope.org</a><br>
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/<u></u>listinfo.cgi/yt-dev-spacepope.<u></u>org</a><br>
</blockquote>
______________________________<u></u>_________________<br>
yt-dev mailing list<br>
<a href="mailto:yt-dev@lists.spacepope.org" target="_blank">yt-dev@lists.spacepope.org</a><br>
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/<u></u>listinfo.cgi/yt-dev-spacepope.<u></u>org</a><br>
</blockquote>
<br>
______________________________<u></u>_________________<br>
yt-dev mailing list<br>
<a href="mailto:yt-dev@lists.spacepope.org" target="_blank">yt-dev@lists.spacepope.org</a><br>
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/<u></u>listinfo.cgi/yt-dev-spacepope.<u></u>org</a><br>
</blockquote>
______________________________<u></u>_________________<br>
yt-dev mailing list<br>
<a href="mailto:yt-dev@lists.spacepope.org" target="_blank">yt-dev@lists.spacepope.org</a><br>
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/<u></u>listinfo.cgi/yt-dev-spacepope.<u></u>org</a><br>
</blockquote>
<br>
______________________________<u></u>_________________<br>
yt-dev mailing list<br>
<a href="mailto:yt-dev@lists.spacepope.org" target="_blank">yt-dev@lists.spacepope.org</a><br>
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/<u></u>listinfo.cgi/yt-dev-spacepope.<u></u>org</a><br>
</blockquote></div>