<div class="gmail_quote">On Tue, Sep 25, 2012 at 3:36 PM, Matthew Turk <span dir="ltr"><<a href="mailto:matthewturk@gmail.com" target="_blank">matthewturk@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Tue, Sep 25, 2012 at 4:32 PM, Anthony Scopatz <<a href="mailto:scopatz@gmail.com">scopatz@gmail.com</a>> wrote:<br>
> Hello All,<br>
><br>
> I have added a fix for this in both 2.x & 3.0. However, I don't have push<br>
> rights<br>
> on 2.x so I simply sent a pull request. If someone can try it out an report<br>
> that<br>
> it works for them we can go ahead and close issue #428.<br>
<br>
</div>Thanks, Anthony! And I've also added you to the core team. We still<br>
try to do most big changes through PRs, but for bug fixes like this<br>
(where the impact is relatively small and the fix obvious) direct<br>
pushes are just fine.<br></blockquote><div><br></div><div>Great, thanks! That seems like a sane development model to me. As you know, </div><div>I'll probably be doing most of my work in 3.0 anyway....</div><div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im"><br>
><br>
> The underlying issue is that IPython has gone to an abstract display model,<br>
> very similar to repr strings but for an interactive environment. See [1].<br>
<br>
</div>This is interesting! Do you think we could leverage this new<br>
development further?<br></blockquote><div><br></div><div>Probably. I don't know how far along they are but I think that the idea is for objects</div><div>to be able to autodisplay themselves in a variety of contexts (notebook, command line, </div>
<div>static html, etc), with the option of having distinct displays for each context. This would</div><div>allow, for instance, Plots to show themselves. This is worth following more, though...</div><div><br></div><div>
Be Well</div><div>Anthony</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
-Matt<br>
<div class="HOEnZb"><div class="h5"><br>
><br>
> Be Well<br>
> Anthony<br>
><br>
> 1.<br>
> <a href="https://github.com/ipython/ipython/commit/1ea9ce2528e5fe5de0b4f9f865cb95322d18e2d6" target="_blank">https://github.com/ipython/ipython/commit/1ea9ce2528e5fe5de0b4f9f865cb95322d18e2d6</a><br>
><br>
> On Tue, Sep 25, 2012 at 2:53 PM, Matthew Turk <<a href="mailto:matthewturk@gmail.com">matthewturk@gmail.com</a>> wrote:<br>
>><br>
>> Can somebody address this? I'd like to ensure we can continue keeping<br>
>> up with IPython (especially since a bunch of us are investing in it<br>
>> quite heavily for our own workflows) but I can't add this to my queue<br>
>> this at the moment. I think the best way to do this is probably to<br>
>> add an IPython compat layer to yt/utilities/ that handles higher-level<br>
>> functionality, since we use relatively little of the IPython API.<br>
>><br>
>> -Matt<br>
>><br>
>><br>
>> ---------- Forwarded message ----------<br>
>> From: Anthony Scopatz <<a href="mailto:issues-reply@bitbucket.org">issues-reply@bitbucket.org</a>><br>
>> Date: Tue, Sep 25, 2012 at 3:49 PM<br>
>> Subject: [yt_analysis/yt] show() failure due to IPython API changes (issue<br>
>> #428)<br>
>> To: <a href="mailto:matthewturk@gmail.com">matthewturk@gmail.com</a><br>
>><br>
>><br>
>> --- you can reply above this line ---<br>
>><br>
>> New issue 428: show() failure due to IPython API changes<br>
>><br>
>> <a href="https://bitbucket.org/yt_analysis/yt/issue/428/show-failure-due-to-ipython-api-changes" target="_blank">https://bitbucket.org/yt_analysis/yt/issue/428/show-failure-due-to-ipython-api-changes</a><br>
>><br>
>> Anthony Scopatz:<br>
>><br>
>> Reporting that the Plot.show() method seems to fail on IPython<br>
>> 0.14-dev because of an API change. The send_figure function is no<br>
>> longer where yt thinks it is.<br>
>><br>
>> {{{python<br>
>> ImportError Traceback (most recent call<br>
>> last)<br>
>> <ipython-input-2-4804b2a8abc5> in <module>()<br>
>> 4 p.annotate_flash_ray_data(pf, 'jet', 10)<br>
>> 5 p.annotate_timestamp(0.2/z, 0.2/z, pf, units="days", size=24)<br>
>> ----> 6 p.show()<br>
>><br>
>><br>
>> /home/scopatz/.local/lib/python2.7/site-packages/yt-3.0dev-py2.7-linux-x86_64.egg/yt/visualization/plot_window.pyc<br>
>> in show(self)<br>
>> 788 """<br>
>> 789 if "__IPYTHON__" in dir(__builtin__):<br>
>> --> 790 self._send_zmq()<br>
>> 791 else:<br>
>> 792 raise YTNotInsideNotebook<br>
>><br>
>><br>
>> /home/scopatz/.local/lib/python2.7/site-packages/yt-3.0dev-py2.7-linux-x86_64.egg/yt/visualization/plot_window.pyc<br>
>> in _send_zmq(self)<br>
>> 763<br>
>> 764 def _send_zmq(self):<br>
>> --> 765 from IPython.zmq.pylab.backend_inline import \<br>
>> 766 send_figure<br>
>> 767 for k, v in sorted(self.plots.iteritems()):<br>
>><br>
>> ImportError: cannot import name send_figure<br>
>> }}}<br>
>><br>
>><br>
>> --<br>
>><br>
>> This is an issue notification from <a href="http://bitbucket.org" target="_blank">bitbucket.org</a>. You are receiving<br>
>> this either because you are the owner of the issue, or you are<br>
>> following the issue.<br>
>> _______________________________________________<br>
>> yt-dev mailing list<br>
>> <a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
>> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
><br>
><br>
><br>
> _______________________________________________<br>
> yt-dev mailing list<br>
> <a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
><br>
_______________________________________________<br>
yt-dev mailing list<br>
<a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
</div></div></blockquote></div><br>