I think we should go for 2.5 release. <div><br></div><div>BTW, an Athena user just found a bug where certain simulations that don't have equal sized grids will not work. I didn't think this was possible but it turns out it is so they or I will be addressing that in the coming days.</div>
<div><br></div><div>If the release is >1month, I would also like to push in some rendering/AMRKDTree improvements. If it <1month, I don't think I'll get to it.<br><div><br></div><div>Sam<br><br><div class="gmail_quote">
On Mon, Sep 10, 2012 at 11:55 AM, Matthew Turk <span dir="ltr"><<a href="mailto:matthewturk@gmail.com" target="_blank">matthewturk@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi all,<br>
<br>
I've merged to the tip of the development repository. The question is<br>
now, do we want to merge to stable from just before the na/np<br>
switchover for an intermediate backport of fixes? Or should we just<br>
push for a faster release cycle on a potential 2.5?<br>
<br>
The main changes (last one month or so) include:<br>
<br>
* Fortran kd-tree building<br>
* Finding outputs fix for cosmology analysis<br>
* Merger tree speedup<br>
* MQK's fixes for cylindrical coordinates in cartesian domains<br>
* Athena frontend (nice, big feature)<br>
* Enzo 1D/2D fixes<br>
* Fixes for FLASH 1D/2D datasets<br>
* load_uniform_data (which is a nice, big feature)<br>
* Grid decomposition<br>
* GDF writer (nice, big feature)<br>
* IO staging<br>
* Some good enhancements and fixes for the callbacks and plot window<br>
* Colorbar fix for healpix camera<br>
<br>
Some of these are things that really warrant a new release, like<br>
Athena and l_u_g, so I am tempted to suggest we hold off and go for<br>
2.5 sometime soon...<br>
<br>
[+-][01] on merging to stable? The hash of the pre-np changeset is<br>
b45aa6c3c142.<br>
<br>
-Matt<br>
<div class="HOEnZb"><div class="h5"><br>
On Fri, Aug 31, 2012 at 9:02 PM, Nathan Goldbaum <<a href="mailto:nathan12343@gmail.com">nathan12343@gmail.com</a>> wrote:<br>
> Hey Matt,<br>
><br>
> Yes, sorry for jumping in without reading the older messages too closely.<br>
><br>
> Long live np!<br>
><br>
> Nathan<br>
><br>
><br>
><br>
> On Sep 1, 2012, at 1:43 AM, Matthew Turk <<a href="mailto:matthewturk@gmail.com">matthewturk@gmail.com</a>> wrote:<br>
><br>
>> I'm going to run tests here. And I am also going to wait until Monday<br>
>> to actually do the merge, because I know a few people who might have<br>
>> thoughts on this are away today but back this weekend.<br>
>><br>
>> Nathan, does keeping na in mods solve the issue you were referencing?<br>
>> I believe the rest should all just be internal -- this change won't<br>
>> affect any userspace scripts, but instead only internal imports. The<br>
>> reason I suggested the merge in advance was to encourage any existing<br>
>> bug fixes to be ported back to stable, as from here on out the patches<br>
>> will likely need to be manually applied.<br>
>><br>
>> -Matt<br>
>><br>
>> On Fri, Aug 31, 2012 at 12:14 PM, Anthony Scopatz <<a href="mailto:scopatz@gmail.com">scopatz@gmail.com</a>> wrote:<br>
>>> PR #258 sent.<br>
>>><br>
>>><br>
>>> On Fri, Aug 31, 2012 at 10:31 AM, Anthony Scopatz <<a href="mailto:scopatz@gmail.com">scopatz@gmail.com</a>> wrote:<br>
>>>><br>
>>>> On Fri, Aug 31, 2012 at 6:06 AM, Matthew Turk <<a href="mailto:matthewturk@gmail.com">matthewturk@gmail.com</a>><br>
>>>> wrote:<br>
>>>>><br>
>>>>> Hi all,<br>
>>>>><br>
>>>>> Okay, looks like everybody's pretty much in favor. Anthony, would it<br>
>>>>> be possible to run the script on the tip of the 2.x repository and<br>
>>>>> issue a PR for that?<br>
>>>><br>
>>>><br>
>>>> Yup, I'll do so within the next hour or so,<br>
>>>><br>
>>>> Be Well<br>
>>>> Anthony<br>
>>>><br>
>>>>><br>
>>>>> And, do we want to merge to stable so that any<br>
>>>>> big bug fixes get applied there before doing so?<br>
>>>>><br>
>>>>> -Matt<br>
>>>>><br>
>>>>> On Mon, Aug 27, 2012 at 2:30 PM, Matthew Turk <<a href="mailto:matthewturk@gmail.com">matthewturk@gmail.com</a>><br>
>>>>> wrote:<br>
>>>>>> Nearly everyone who has replied so far is on board with the third<br>
>>>>>> option, which is to apply the same change to both. Anthony and Kacper<br>
>>>>>> also had a discussion in the PR about the cosmology routines, which<br>
>>>>>> seem to be (!!!) non-functional in some particular configurations of<br>
>>>>>> the universe. I'll suggest that we wait until Wednesday, and if<br>
>>>>>> nobody objects by then, we accept this PR and then also a similar one<br>
>>>>>> for the dev branch. I'd prefer we not apply these changes to the<br>
>>>>>> stable branch at this time.<br>
>>>>>><br>
>>>>>> In IRC, Martin Geisler also pointed me at these StackOverflow<br>
>>>>>> questions which address merges and workflows like this:<br>
>>>>>><br>
>>>>>> <a href="http://stackoverflow.com/a/9533927/110204" target="_blank">http://stackoverflow.com/a/9533927/110204</a><br>
>>>>>> <a href="http://stackoverflow.com/a/9500764/110204" target="_blank">http://stackoverflow.com/a/9500764/110204</a><br>
>>>>>><br>
>>>>>> In short, by applying to both, we're going to be okay. :)<br>
>>>>>><br>
>>>>>> -Matt<br>
>>>>>><br>
>>>>>> On Mon, Aug 27, 2012 at 1:47 PM, Anthony Scopatz <<a href="mailto:scopatz@gmail.com">scopatz@gmail.com</a>><br>
>>>>>> wrote:<br>
>>>>>>> Hello All,<br>
>>>>>>><br>
>>>>>>> Obviously, I am +1 for #3 and +0 on #2 (no need to create a<br>
>>>>>>> maintenance<br>
>>>>>>> headache if you don't have to). I originally did this in the 3.0 fork<br>
>>>>>>> just<br>
>>>>>>> because<br>
>>>>>>> I thought it was more of a sandbox than the 2.x series. I am also +0<br>
>>>>>>> on #1,<br>
>>>>>>> if that is what is best.<br>
>>>>>>><br>
>>>>>>> Be Well<br>
>>>>>>> Anthony<br>
>>>>>>><br>
>>>>>>><br>
>>>>>>> On Mon, Aug 27, 2012 at 9:54 AM, Kacper Kowalik<br>
>>>>>>> <<a href="mailto:xarthisius.kk@gmail.com">xarthisius.kk@gmail.com</a>><br>
>>>>>>> wrote:<br>
>>>>>>>><br>
>>>>>>>> On <a href="tel:27.08.2012%2016" value="+12708201216">27.08.2012 16</a>:08, Matthew Turk wrote:<br>
>>>>>>>>> Because this could be disruptive for any major, outstanding forks,<br>
>>>>>>>>> I<br>
>>>>>>>>> also think it needs to be discussed here. (I'm actually kind of -1<br>
>>>>>>>>> on<br>
>>>>>>>>> big discussions happening in pull requests.) My vote is for #3.<br>
>>>>>>>>> I'd<br>
>>>>>>>>> rather get this over with, since we all know it probably ought to<br>
>>>>>>>>> happen at some point in the future.<br>
>>>>>>>><br>
>>>>>>>> Hi,<br>
>>>>>>>> there's a way to minimize the disruption on any outstanding forks,<br>
>>>>>>>> namely to automate the process. If we use the same "tool" on both<br>
>>>>>>>> main<br>
>>>>>>>> repo and the fork, the difference should be close to none.<br>
>>>>>>>> In this case something along the lines:<br>
>>>>>>>><br>
>>>>>>>> find . -name "*.py" \<br>
>>>>>>>> -exec sed -e "s/\([[:punct:]]\|[[:space:]]\)na\./\1np\./g" \<br>
>>>>>>>> -e "s/numpy as na/numpy as np/g" -i {} \;<br>
>>>>>>>><br>
>>>>>>>> should do the trick. I haven't check yet if that reproduces Anthony's<br>
>>>>>>>> PR<br>
>>>>>>>> so use it carefully ;)<br>
>>>>>>>> Cheers,<br>
>>>>>>>> Kacper<br>
>>>>>>>><br>
>>>>>>>><br>
>>>>>>>><br>
>>>>>>>> _______________________________________________<br>
>>>>>>>> yt-dev mailing list<br>
>>>>>>>> <a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
>>>>>>>> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
>>>>>>>><br>
>>>>>>><br>
>>>>>>><br>
>>>>>>> _______________________________________________<br>
>>>>>>> yt-dev mailing list<br>
>>>>>>> <a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
>>>>>>> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
>>>>>>><br>
>>>>> _______________________________________________<br>
>>>>> yt-dev mailing list<br>
>>>>> <a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
>>>>> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
>>>><br>
>>>><br>
>>><br>
>>><br>
>>> _______________________________________________<br>
>>> yt-dev mailing list<br>
>>> <a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
>>> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
>>><br>
>> _______________________________________________<br>
>> yt-dev mailing list<br>
>> <a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
>> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
> _______________________________________________<br>
> yt-dev mailing list<br>
> <a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
_______________________________________________<br>
yt-dev mailing list<br>
<a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
</div></div></blockquote></div><br></div></div>