+1 on #3.<br><br><div class="gmail_quote">On Mon, Aug 27, 2012 at 10:27 AM, Sam Skillman <span dir="ltr"><<a href="mailto:samskillman@gmail.com" target="_blank">samskillman@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
1) +0<div>2) -1</div><div>3) +1</div><div><br></div><div>Rip the bandaid.<div><div class="h5"><br><br><div class="gmail_quote">On Mon, Aug 27, 2012 at 8:25 AM, John ZuHone <span dir="ltr"><<a href="mailto:jzuhone@gmail.com" target="_blank">jzuhone@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">My vote is #3, since otherwise we'll be faced with the same trilemma later if we don't.<br>
<br>
John ZuHone<br>
Laboratory for High-Energy Astrophysics<br>
NASA/Goddard Space Flight Center<br>
8800 Greenbelt Rd., Code 662<br>
Greenbelt, MD 20771<br>
(w) <a href="tel:301-286-2531" value="+13012862531" target="_blank">301-286-2531</a><br>
(m) <a href="tel:773-758-0172" value="+17737580172" target="_blank">773-758-0172</a><br>
<a href="mailto:jzuhone@gmail.com" target="_blank">jzuhone@gmail.com</a><br>
<a href="mailto:john.zuhone@nasa.gov" target="_blank">john.zuhone@nasa.gov</a><br>
<div><div><br>
On Aug 27, 2012, at 10:08 AM, Matthew Turk <<a href="mailto:matthewturk@gmail.com" target="_blank">matthewturk@gmail.com</a>> wrote:<br>
<br>
> Hi all,<br>
><br>
> On Friday, Anthony submitted a PR to the yt-3.0 branch:<br>
><br>
> <a href="https://bitbucket.org/yt_analysis/yt-3.0/pull-request/4/na-is-dead-long-live-np" target="_blank">https://bitbucket.org/yt_analysis/yt-3.0/pull-request/4/na-is-dead-long-live-np</a><br>
><br>
> This PR is pretty invasive, and done by regular expressions.<br>
> Basically, for a long time we've been sticking with a convention I<br>
> started using about ... six years ago ... when NumArray was the<br>
> dominant array language. (Or when I was still too removed from<br>
> Python's scientific community to see otherwise.) The array library<br>
> was shortened to 'na'. Almost immediately after, NumPy took over and<br>
> while we switched to NumPy we never updated the shorthand in the<br>
> Python code to 'np'. (The Cython code always uses 'np') Most python<br>
> tutorials use np instead of numpy, and I'd like to encourage best<br>
> practices in yt as well as suggest we try to fit into the broader<br>
> ecosystem of packages.<br>
><br>
> Anyway, this is kind of a bandaid that needs to be ripped off at some<br>
> point, and I think it's appropriate to discuss now. I see three<br>
> options, which basically break down on levels of disruption and ease<br>
> of the dual-lines of development we currently have.<br>
><br>
> 1) Put this PR (which applies only to 3.0) on hold. This way, merging<br>
> from 2.x to 3.0 can proceed easily, and the disruption is completely<br>
> pushed off for a bit.<br>
> 2) Accept the PR. This increases the burden on me for merging<br>
> considerably, and it would fall on me. Any file where both a numpy<br>
> line and another line are changed would throw a conflict that I'd have<br>
> to manually resolve. But, because it would just be in the 3.0 line,<br>
> disruption would be kept to a minimum.<br>
> 3) Accept the PR *but* also mandate that we apply it to the main<br>
> repository's development branch (2.x). This would be the most<br>
> disruptive, but it would also keep merging difficulty to a minimum.<br>
> As a compatibility layer, we'll keep "na" in the yt.mods namespace,<br>
> which means my_plugins.py files would still work, as would existing<br>
> scripts.<br>
><br>
> Because this could be disruptive for any major, outstanding forks, I<br>
> also think it needs to be discussed here. (I'm actually kind of -1 on<br>
> big discussions happening in pull requests.) My vote is for #3. I'd<br>
> rather get this over with, since we all know it probably ought to<br>
> happen at some point in the future.<br>
><br>
> What do people think -- of the three options, which is your favorite,<br>
> and do you have strong feelings against any one option?<br>
><br>
> -Matt<br>
> _______________________________________________<br>
> yt-dev mailing list<br>
> <a href="mailto:yt-dev@lists.spacepope.org" target="_blank">yt-dev@lists.spacepope.org</a><br>
> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
_______________________________________________<br>
yt-dev mailing list<br>
<a href="mailto:yt-dev@lists.spacepope.org" target="_blank">yt-dev@lists.spacepope.org</a><br>
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
</div></div></blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
yt-dev mailing list<br>
<a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
<br></blockquote></div><br>