Additionally, the LightCone and LightRay will get a refactor in the near future to work with the new general SimulationTimeSeries class instead of being enzo specific. I hope to clean up some other things that may have picked up a little rust with time.<br>
<br>Britton<br><br><div class="gmail_quote">On Fri, Jun 15, 2012 at 2:04 PM, Britton Smith <span dir="ltr"><<a href="mailto:brittonsmith@gmail.com" target="_blank">brittonsmith@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Stephen,<br><br>Thanks for catching all this. Your changes all look good to me, with one suggestion.<br><br>I recommend replacing set_parameters=None and then adding a line:<br>if set_parameters is None: set_parameters={}<br>
When setting the empty dist in the kwarg, you can run into situations where things can get stuck in that dict from previous calls to that function, since it's a pointer.<del></del><br>Other than that, it looks great. I'll accept the PR when you submit one.<br>
The add_redshift_label kwarg was removed when use of the PlotCollection to generate the projections was dropped. Thanks for catching that, too.<span class="HOEnZb"><font color="#888888"><br><br>Britton</font></span><div class="HOEnZb">
<div class="h5"><br><br><div class="gmail_quote">On Fri, Jun 15, 2012 at 12:00 PM, Stephen Skory <span dir="ltr"><<a href="mailto:s@skory.us" target="_blank">s@skory.us</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
I have been messing around with the example light cone generator<br>
example for halos:<br>
<br>
<a href="http://yt-project.org/doc/cookbook/index.html#cookbook-light-cone-halo-mask" target="_blank">http://yt-project.org/doc/cookbook/index.html#cookbook-light-cone-halo-mask</a><br>
<br>
and I have come across a few issues. My guess is that the various<br>
things the light cone uses (the halo profiler, FRB) have changed<br>
underneath the light cone. I think I've got it working with some<br>
changes, but at least one is not a good permanent solution, and I'd<br>
like Britton eyes on this since I don't really understand all the<br>
details of the LC and I'm not sure that these changes are good.<br>
<br>
1. In the example above, the "add_redshift_label" keyword to<br>
"project_light_cone()" doesn't appear to exist any more.<br>
<br>
2. I've made these changes to the yt source to get things to work:<br>
<br>
<a href="http://paste.yt-project.org/show/2466/" target="_blank">http://paste.yt-project.org/show/2466/</a><br>
<br>
a. The changes to halo_mask.py are hacks. It appears that the halo<br>
profiler now adds the overdensity factor to "RadiusMpc" and<br>
"TotalMassMsun" (e.g. "RadiusMpc_200"). It seems to me that the<br>
correct way to fix this is to pass the halo profiler kwargs down to<br>
the _make_slice_halo_list() function where these lines appear so the<br>
overdensity factor can be included in these strings. What do you<br>
think?<br>
<br>
b. In light_cone.py I've changed the default of set_parameters to an<br>
empty dict, which dict.update() accepts to perform no action, when<br>
None makes it croak.<br>
<br>
c. frb.field_data[] doesn't appear to work.<br>
<br>
Thanks!<br>
<span><font color="#888888"><br>
--<br>
Stephen Skory<br>
<a href="mailto:s@skory.us" target="_blank">s@skory.us</a><br>
<a href="http://stephenskory.com/" target="_blank">http://stephenskory.com/</a><br>
<a href="tel:510.621.3687" value="+15106213687" target="_blank">510.621.3687</a> (google voice)<br>
_______________________________________________<br>
yt-dev mailing list<br>
<a href="mailto:yt-dev@lists.spacepope.org" target="_blank">yt-dev@lists.spacepope.org</a><br>
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
</font></span></blockquote></div><br>
</div></div></blockquote></div><br>