Hi Stephen.<div><br></div><div>Not sure about all of the pep8 suggestions, but I think this is important. Some are purely style/consistency, like <span style>whitespace before ')'. Some would hold yt back from Python3 in the future, like </span><span style>.has_key() is deprecated, use 'in'.</span></div>
<div><br></div><div>Do you think it will be enough to autopep and run the full tests? I have no idea about coverage, but it would be great to fix some of these.</div><div><br></div><div>Best,</div><div>Casey</div><div><br>
<br><div class="gmail_quote">On Tue, Jan 31, 2012 at 7:00 PM, Stephen Skory <span dir="ltr"><<a href="mailto:s@skory.us" target="_blank">s@skory.us</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi all,<br>
<br>
while vegging out in front of the TV, I've been playing with a pep8<br>
checker (<a href="http://pypi.python.org/pypi/pep8" target="_blank">http://pypi.python.org/pypi/pep8</a>), and I get the statistics<br>
below for all the *.py files in yt. How much do we care about this<br>
stuff? There are automatic tools<br>
(<a href="http://pypi.python.org/pypi/autopep8/0.3" target="_blank">http://pypi.python.org/pypi/autopep8/0.3</a>) but I don't know if we can<br>
trust them. Thoughts?<br>
<br>
(the first column is the number of incidents)<br>
<br>
70 E101 indentation contains mixed spaces and tabs<br>
76 E111 indentation is not a multiple of four<br>
605 E201 whitespace after '['<br>
68 E202 whitespace before ')'<br>
94 E203 whitespace before ','<br>
105 E211 whitespace before '['<br>
191 E221 multiple spaces before operator<br>
57 E222 multiple spaces after operator<br>
3769 E225 missing whitespace around operator<br>
4271 E231 missing whitespace after ','<br>
1080 E251 no spaces around keyword / parameter equals<br>
986 E261 at least two spaces before inline comment<br>
6 E262 inline comment should start with '# '<br>
414 E301 expected 1 blank line, found 0<br>
2061 E302 expected 2 blank lines, found 1<br>
369 E303 too many blank lines (2)<br>
168 E401 multiple imports on one line<br>
4644 E501 line too long (80 characters)<br>
1760 E701 multiple statements on one line (colon)<br>
276 E702 multiple statements on one line (semicolon)<br>
70 W191 indentation contains tabs<br>
1585 W291 trailing whitespace<br>
3 W292 no newline at end of file<br>
3163 W293 blank line contains whitespace<br>
221 W391 blank line at end of file<br>
197 W601 .has_key() is deprecated, use 'in'<br>
17 W602 deprecated form of raising exception<br>
<span><font color="#888888"><br>
--<br>
Stephen Skory<br>
<a href="mailto:s@skory.us" target="_blank">s@skory.us</a><br>
<a href="http://stephenskory.com/" target="_blank">http://stephenskory.com/</a><br>
<a href="tel:510.621.3687" value="+15106213687" target="_blank">510.621.3687</a> (google voice)<br>
_______________________________________________<br>
yt-dev mailing list<br>
<a href="mailto:yt-dev@lists.spacepope.org" target="_blank">yt-dev@lists.spacepope.org</a><br>
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
</font></span></blockquote></div><br></div>