Thanks Matt, works great!<div><br></div><div>Sam<br><br><div class="gmail_quote">On Wed, Jan 4, 2012 at 9:12 AM, Matthew Turk <span dir="ltr"><<a href="mailto:matthewturk@gmail.com">matthewturk@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Sam,<br>
<br>
Thanks for the data. I got it working by removing the (empty)<br>
overriding of _setup_unknown_fields in the gdf frontend. What this<br>
function is supposed to do is populate field_info with either Known<br>
fields or new fields. It was not doing either, since it was<br>
overridden. The fix is in f8ef14cd6da8 in my repo.<br>
<br>
-Matt<br>
<div class="HOEnZb"><div class="h5"><br>
On Wed, Jan 4, 2012 at 10:55 AM, Sam Skillman <<a href="mailto:samskillman@gmail.com">samskillman@gmail.com</a>> wrote:<br>
> Hi Matt,<br>
><br>
> That didn't seem to help. With that change I still get the same errors.<br>
><br>
> I have put a 64MB dataset here:<br>
> <a href="http://corvette.colorado.edu/~skillman/simulations/kh_3d_mhd_hlld_128_beta5000_sub_tanhd.0030.gdf" target="_blank">http://corvette.colorado.edu/~skillman/simulations/kh_3d_mhd_hlld_128_beta5000_sub_tanhd.0030.gdf</a><br>
><br>
> which can be loaded with<br>
> yt load kh_3d_mhd_hlld_128_beta5000_sub_tanhd.0030.gdf<br>
><br>
> I have had to make some changes to other parts of the gdf frontend, so you<br>
> should probably work off the yt-gdf fork tip:<br>
> <a href="https://bitbucket.org/samskillman/yt-gdf/changeset/57483ef32927" target="_blank">https://bitbucket.org/samskillman/yt-gdf/changeset/57483ef32927</a><br>
><br>
> I'm around on IRC now as well.<br>
><br>
> Thanks,<br>
> Sam<br>
><br>
><br>
> On Wed, Jan 4, 2012 at 4:57 AM, Matthew Turk <<a href="mailto:matthewturk@gmail.com">matthewturk@gmail.com</a>> wrote:<br>
>><br>
>> Hi Sam,<br>
>><br>
>> On Wed, Jan 4, 2012 at 6:52 AM, Matthew Turk <<a href="mailto:matthewturk@gmail.com">matthewturk@gmail.com</a>><br>
>> wrote:<br>
>> > Hi Sam,<br>
>> ><br>
>> > On Tue, Jan 3, 2012 at 9:01 PM, Sam Skillman <<a href="mailto:samskillman@gmail.com">samskillman@gmail.com</a>><br>
>> > wrote:<br>
>> >> Hi all,<br>
>> >><br>
>> >> I'm running into an issue with translation dictionaries for the GDF<br>
>> >> frontend.<br>
>> >><br>
>> >> On the tip, if I load up a gdf dataset, and do:<br>
>> >><br>
>> >> pf.h.find_max('Density')<br>
>> >><br>
>> >> I get:<br>
>> >><br>
>> >> <a href="http://paste.yt-project.org/show/2008/" target="_blank">http://paste.yt-project.org/show/2008/</a><br>
>> >><br>
>> >> If I instead do pf.h.find_max('density'), I get what looks like the<br>
>> >> same<br>
>> >> error.<br>
>> >><br>
>> >> If I replace line 56 in yt/frontends/gdf/fields.py<br>
>> >><br>
>> >> 55 KnownGDFFields = FieldInfoContainer()<br>
>> >> 56 add_gdf_field = KnownGDFFields.add_field<br>
>> >><br>
>> >> with<br>
>> >><br>
>> >> 57 add_gdf_field = GDFFieldInfo.add_field<br>
>> >><br>
>> >> It works fine.<br>
>> ><br>
>> > Hm, this is the opposite of what I'd expect. "Known" is to indicate<br>
>> > that a field may exist in a file, whereas the standard is to indicate<br>
>> > it can be derived. By that logic, "Known" is where "density" should<br>
>> > go and standard is where "Density" should go, which in my version of<br>
>> > the code is how it is done.<br>
>><br>
>> One quick thought. Can you try with the validators for 'density'<br>
>> removed, using the standard code as it is in the tip of the main repo?<br>
>> i.e., change<br>
>><br>
>> add_gdf_field("density", function=NullFunc, take_log=True,<br>
>> validators = [ValidateDataField("density")],<br>
>> units=r"\rm{g}/\rm{cm}^3",<br>
>> projected_units =r"\rm{g}/\rm{cm}^2")<br>
>><br>
>> to<br>
>><br>
>> add_gdf_field("density", function=NullFunc, take_log=True,<br>
>> units=r"\rm{g}/\rm{cm}^3",<br>
>> projected_units =r"\rm{g}/\rm{cm}^2")<br>
>><br>
>> -Matt<br>
>><br>
>> ><br>
>> > Can you supply a small sample GDF dataset so I can dig in?<br>
>> ><br>
>> > -Matt<br>
>> ><br>
>> >><br>
>> >> Alternatively, if I replace<br>
>> >><br>
>> >> 96 for f,v in log_translation_dict.items():<br>
>> >> 97 add_field(f, function=TranslationFunc(v), take_log=True)<br>
>> >> 98<br>
>> >> 99 for f,v in translation_dict.items():<br>
>> >> 100 add_field(f, function=TranslationFunc(v), take_log=False)<br>
>> >><br>
>> >> with<br>
>> >><br>
>> >> 102 def _generate_translation(mine, theirs, take_log=False):<br>
>> >> 103 add_field(theirs, function=lambda a, b: b[mine],<br>
>> >> take_log=take_log)<br>
>> >> 104<br>
>> >> 105<br>
>> >> 106 for f,v in log_translation_dict.items():<br>
>> >> 107 if v not in GDFFieldInfo:<br>
>> >> 108 add_field(v, function=lambda a,b: None, take_log=True,<br>
>> >> 109 validators = [ValidateDataField(v)])<br>
>> >> 110 #print "Setting up translator from %s to %s" % (v, f)<br>
>> >> 111 _generate_translation(v, f, take_log=True)<br>
>> >> 112<br>
>> >> 113<br>
>> >> 114 for f,v in translation_dict.items():<br>
>> >> 115 if v not in GDFFieldInfo:<br>
>> >> 116 add_field(v, function=lambda a,b: None, take_log=False,<br>
>> >> 117 validators = [ValidateDataField(v)])<br>
>> >> 118 #print "Setting up translator from %s to %s" % (v, f)<br>
>> >> 119 _generate_translation(v, f, take_log=False)<br>
>> >><br>
>> >> as is done in the orion reader, it works fine.<br>
>> >><br>
>> >> Anyways, if someone sees what is going on here, let me know. I'll also<br>
>> >> be<br>
>> >> on IRC for a bit longer tonight and all tomorrow.<br>
>> >><br>
>> >> Thanks,<br>
>> >> Sam<br>
>> >><br>
>> >> _______________________________________________<br>
>> >> yt-dev mailing list<br>
>> >> <a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
>> >> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
>> >><br>
>> _______________________________________________<br>
>> yt-dev mailing list<br>
>> <a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
>> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
><br>
><br>
><br>
> _______________________________________________<br>
> yt-dev mailing list<br>
> <a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
> <a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
><br>
_______________________________________________<br>
yt-dev mailing list<br>
<a href="mailto:yt-dev@lists.spacepope.org">yt-dev@lists.spacepope.org</a><br>
<a href="http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org" target="_blank">http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org</a><br>
</div></div></blockquote></div><br></div>