[yt-dev] Request for review Python 3 changes

Michael Zingale michael.zingale at stonybrook.edu
Wed Jan 21 16:38:50 PST 2015


Can you expand on that, I'm not quite sure I understand.  On import with
Python 3 I got an error with a print that was not a function.
On Jan 21, 2015 4:32 PM, "Matthew Turk" <matthewturk at gmail.com> wrote:

> Hi Mike,
>
> Does it work if you install instead of importing from the source Dir? It
> works for me on Py3.
>
> On Wed, Jan 21, 2015, 4:57 PM Michael Zingale <
> michael.zingale at stonybrook.edu> wrote:
>
>> Yeah, I approved it based on it working with python 2
>>
>> On Tue, Jan 20, 2015 at 7:42 AM, Matthew Turk <matthewturk at gmail.com>
>> wrote:
>>
>>> Hi Mike,
>>>
>>> Both, actually.  :)  But I think if we can say that it works under 2 we
>>> can accept it, and then iterate on finishing up any remaining 3 work.
>>>
>>> On Sun, Jan 18, 2015 at 5:51 PM, Michael Zingale <
>>> michael.zingale at stonybrook.edu> wrote:
>>>
>>>> or are you looking for help testing the python3 bookmark under python
>>>> 2.x?  (keep wanting to call it a 'branch'... dang git/hg conflicting
>>>> terms...)
>>>>
>>>> On Sun, Jan 18, 2015 at 4:51 PM, Matthew Turk <matthewturk at gmail.com>
>>>> wrote:
>>>>
>>>>> Hi all,
>>>>>
>>>>> I'd like to request review on this PR from me, Jill, Kacper and Nathan:
>>>>>
>>>>>
>>>>> https://bitbucket.org/yt_analysis/yt/pull-request/1177/wip-second-set-of-python-3-fixes
>>>>>
>>>>> I think accepting should wait until we get the bugfix/newdev
>>>>> discussion finished, but I think it's now past WIP.
>>>>>
>>>>> (If we decide to do all bugfixes on stable, I think it could go in
>>>>> relatively soon, pending review.)
>>>>>
>>>>> -Matt
>>>>>
>>>>> _______________________________________________
>>>>> yt-dev mailing list
>>>>> yt-dev at lists.spacepope.org
>>>>> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Michael Zingale
>>>> Associate Professor
>>>>
>>>> Dept. of Physics & Astronomy • Stony Brook University • Stony Brook, NY
>>>> 11794-3800
>>>> *phone*:  631-632-8225
>>>> *e-mail*: Michael.Zingale at stonybrook.edu
>>>> *web*: http://www.astro.sunysb.edu/mzingale
>>>>
>>>> _______________________________________________
>>>> yt-dev mailing list
>>>> yt-dev at lists.spacepope.org
>>>> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
>>>>
>>>>
>>>
>>> _______________________________________________
>>> yt-dev mailing list
>>> yt-dev at lists.spacepope.org
>>> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
>>>
>>>
>>
>>
>> --
>> Michael Zingale
>> Associate Professor
>>
>> Dept. of Physics & Astronomy • Stony Brook University • Stony Brook, NY
>> 11794-3800
>> *phone*:  631-632-8225
>> *e-mail*: Michael.Zingale at stonybrook.edu
>> *web*: http://www.astro.sunysb.edu/mzingale
>>  _______________________________________________
>> yt-dev mailing list
>> yt-dev at lists.spacepope.org
>> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
>>
>
> _______________________________________________
> yt-dev mailing list
> yt-dev at lists.spacepope.org
> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.spacepope.org/pipermail/yt-dev-spacepope.org/attachments/20150121/aab9d169/attachment.html>
-------------- next part --------------
_______________________________________________
yt-dev mailing list
yt-dev at lists.spacepope.org
http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org


More information about the yt-dev mailing list