[yt-dev] near duplicate to_frb functions in YTCuttingPlaneBase

Britton Smith brittonsmith at gmail.com
Tue Oct 14 13:42:14 PDT 2014


Hi Nathan,

Ok, I can do that.  My concern was that the active function may not
necessarily be the one that the developer meant to keep, but is just the
one that happens to be getting called.  However, it's probably a safe
assumption that the active function is the correct one, so I'll do that.

Britton

On Tue, Oct 14, 2014 at 4:38 PM, Nathan Goldbaum <nathan12343 at gmail.com>
wrote:

> Hi Britton,
>
> You can tell for yourself by putting a breakpoint in each and then calling
> the function. You'll end up in a breakpoint inside the "active" function,
> so you can delete the other one.
>
> Thanks for taking care of this!
>
> Nathan
>
> On Tuesday, October 14, 2014, Britton Smith <brittonsmith at gmail.com>
> wrote:
>
>> Hi all,
>>
>> I was just looking through yt/data_object/selection_data_containers.py
>> and noticed that there are two nearly identical YTCuttingPlaneBase.to_frb
>> functions.  They are almost the same with just a different kwarg and one
>> other line.  This may have been a bad merge.  Can someone who is familiar
>> with this area take a quick look and either get rid of one or tell me which
>> one should be removed?
>>
>> Thanks,
>> Britton
>>
>
> _______________________________________________
> yt-dev mailing list
> yt-dev at lists.spacepope.org
> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.spacepope.org/pipermail/yt-dev-spacepope.org/attachments/20141014/ff1620cf/attachment.htm>


More information about the yt-dev mailing list