[yt-dev] Hop in yt-3

[Brian O'Shea]

Thank you, Nathan.  I will test it shortly and will report back!

--Brian



On Tue, May 27, 2014 at 2:55 AM, Nathan Goldbaum <nathan12343 at gmail.com>wrote:

> It ended up being due to the halo finding code using a feature of ndarray
> I didn't know existed and therefore wasn't reflected in the design of
> YTArray.  This defect should hopefully be fixed (and tested!) here:
>
>
> https://bitbucket.org/yt_analysis/yt/pull-request/926/improved-compatibility-for-ytarray/diff
>
> If you could try that script after applying the PR and then leave a
> comment saying it it worked or not, I'd appreciate it.
>
> Thanks!
>
> -Nathan
>
>
> On Mon, May 26, 2014 at 7:31 PM, Nathan Goldbaum <nathan12343 at gmail.com>wrote:
>
>> Hey Brian,
>>
>> Sorry for the trouble - this is due to a recent change to make YTArray
>> subclasses behave more naturally.
>>
>> I've managed to reproduce this locally using the following script:
>>
>> http://paste.yt-project.org/show/4684/
>>
>> I will hopefully have a PR for you to test soon.
>>
>> -Nathan
>>
>>
>> On Mon, May 26, 2014 at 6:22 PM, Brian O'Shea <bwoshea at gmail.com> wrote:
>>
>>> Hi folks,
>>>
>>> I just tried to do some halo-finding with yt-3 using Hop (the current
>>> tip; rev 3cfb38afe34d), and it died somewhere after calling 'regroup' with
>>> this error:
>>>
>>> Traceback (most recent call last):
>>>   File "hop.py", line 11, in <module>
>>>     halo_list = HaloFinder(pf, subvolume=my_subregion)
>>>   File "/mnt/a/u/sciteam/bwoshea/yt-3.0/src/yt-hg/yt/analysis_modules/halo_finding/halo_objects.py", line 2440, in __init__
>>>     self._join_halolists()
>>>   File "/mnt/a/u/sciteam/bwoshea/yt-3.0/src/yt-hg/yt/analysis_modules/halo_finding/halo_objects.py", line 1889, in _join_halolists
>>>     self._groups.sort(haloCmp)
>>>   File "/mnt/a/u/sciteam/bwoshea/yt-3.0/src/yt-hg/yt/analysis_modules/halo_finding/halo_objects.py", line 1888, in haloCmp
>>>     return cmp(h1.center_of_mass()[0], h2.center_of_mass()[0])
>>>   File "/mnt/a/u/sciteam/bwoshea/yt-3.0/src/yt-hg/yt/utilities/parallel_tools/parallel_analysis_interface.py", line 191, in single_proc_results
>>>     retval = func(self, *args, **kwargs)
>>>   File "/mnt/a/u/sciteam/bwoshea/yt-3.0/src/yt-hg/yt/analysis_modules/halo_finding/halo_objects.py", line 158, in center_of_mass
>>>     c = (com * pm).sum(axis=1) / pm.sum()
>>>   File "/mnt/a/u/sciteam/bwoshea/yt-3.0/src/yt-hg/yt/units/yt_array.py", line 648, in __rmul__
>>>     return YTArray(super(YTArray, self).__rmul__(lo))
>>>   File "/mnt/a/u/sciteam/bwoshea/yt-3.0/src/yt-hg/yt/units/yt_array.py", line 910, in __array_wrap__
>>>     ret_class = get_binary_op_return_class(cls1, cls2)
>>>   File "/mnt/a/u/sciteam/bwoshea/yt-3.0/src/yt-hg/yt/units/yt_array.py", line 1045, in get_binary_op_return_class
>>>     raise RuntimeError("Operations are only defined on pairs of objects"
>>> RuntimeError: Operations are only defined on pairs of objectsin which one is a subclass of the other
>>>
>>>
>>> It was functional roughly two weeks ago (on May 10), when I successfully
>>> did halo-finding on the same machine with yt-3.  Looking at the errors, it
>>> seems to be something more general than Hop functionality, but I'm not
>>> entirely sure.  Does anybody have any thoughts on this?
>>>
>>> Also, for the sake of completeness, you can see my batch and python
>>> scripts:
>>>
>>>   http://paste.yt-project.org/show/4681/
>>>    http://paste.yt-project.org/show/4682/
>>>
>>> And the full output log from the run:
>>>
>>>   http://paste.yt-project.org/show/4683/
>>>
>>> And, again, this is using the current tip of yt-3.
>>>
>>> Thanks!
>>>
>>> --Brian
>>>
>>> _______________________________________________
>>> yt-dev mailing list
>>> yt-dev at lists.spacepope.org
>>> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
>>>
>>>
>>
>
> _______________________________________________
> yt-dev mailing list
> yt-dev at lists.spacepope.org
> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.spacepope.org/pipermail/yt-dev-spacepope.org/attachments/20140527/6175036f/attachment.html>