[yt-dev] Globally replacing pf with ds?

Nathan Goldbaum nathan12343 at gmail.com
Thu Jun 19 09:15:59 PDT 2014


Can you leave a comment to that effect on the PR so I don't forget?

On Thursday, June 19, 2014, Matthew Turk <matthewturk at gmail.com> wrote:

> Hi Nathan,
>
> I'm ready to hit the button any time, although I wonder if we ought to
> have a compat layer for a little while -- a property for .pf for
> instance.
>
> -Matt
>
> On Thu, Jun 19, 2014 at 1:12 AM, Nathan Goldbaum <nathan12343 at gmail.com
> <javascript:;>> wrote:
> > This is ready now and passes all of the unit and answer tests:
> >
> >
> https://bitbucket.org/yt_analysis/yt/pull-request/954/replacing-pf-with-ds/diff#chg-doc/docstring_idioms.txt
> >
> > Should we wait to merge this in until we can cut down on the PR backlog?
> >
> >
> > On Thu, Jun 12, 2014 at 9:29 AM, Matthew Turk <matthewturk at gmail.com
> <javascript:;>> wrote:
> >>
> >> We usually use "convert-repo" for this purpose.
> >>
> >> On Thu, Jun 12, 2014 at 10:27 AM, Sam Skillman <samskillman at gmail.com
> <javascript:;>>
> >> wrote:
> >> > +1, as it is in line with
> >> > http://ytep.readthedocs.org/en/latest/YTEPs/YTEP-0017.html. Perhaps
> use
> >> > a
> >> > different username like 'rename-pf' or something so that hg blame is
> >> > useful
> >> > for figuring out what was the cause? Also this should probably be done
> >> > at a
> >> > point when the number of open PRs is low.
> >> >
> >> >
> >> > On Wed, Jun 11, 2014 at 3:40 PM, Cameron Hummels <chummels at gmail.com
> <javascript:;>>
> >> > wrote:
> >> >>
> >> >> +1 since this will provide consistency with docs and make more sense
> >> >> for
> >> >> new users.  I support doing this asap so that any bugs can be dealt
> >> >> with
> >> >> prior to release.
> >> >>
> >> >> Cameron
> >> >>
> >> >>
> >> >> On Wed, Jun 11, 2014 at 3:36 PM, Stuart Mumford <
> stuart at mumford.me.uk <javascript:;>>
> >> >> wrote:
> >> >>>
> >> >>> +1 fwiw
> >> >>>
> >> >>> Stuart
> >> >>>
> >> >>> On 11 Jun 2014 22:55, "John ZuHone" <jzuhone at gmail.com
> <javascript:;>> wrote:
> >> >>>>
> >> >>>> +1 for me.
> >> >>>>
> >> >>>> On Jun 11, 2014, at 5:53 PM, Nathan Goldbaum <
> nathan12343 at gmail.com <javascript:;>>
> >> >>>> wrote:
> >> >>>>
> >> >>>> > Hi all,
> >> >>>> >
> >> >>>> > Before 3.0 goes out, how do you all feel about a PR that replaces
> >> >>>> > "pf"
> >> >>>> > with "ds" across the whole codebase?
> >> >>>> >
> >> >>>> > I think this is worth doing, since it reduces the cognitive load
> of
> >> >>>> > dealing with yt internals.  One downside is that it will break
> user
> >> >>>> > scripts
> >> >>>> > if they're using internal APIs.  It will also be a big,
> >> >>>> > difficult-to-review
> >> >>>> > PR.
> >> >>>> >
> >> >>>> > Now is the time to do this if it ever gets done since there are a
> >> >>>> > large number of other breaking changes in 3.0.
> >> >>>> >
> >> >>>> > I'd be happy to do this if there's a consensus that it's worth
> >> >>>> > doing.
> >> >>>> >
> >> >>>> > Nathan
> >> >>>> > _______________________________________________
> >> >>>> > yt-dev mailing list
> >> >>>> > yt-dev at lists.spacepope.org <javascript:;>
> >> >>>> > http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
> >> >>>>
> >> >>>> _______________________________________________
> >> >>>> yt-dev mailing list
> >> >>>> yt-dev at lists.spacepope.org <javascript:;>
> >> >>>> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
> >> >>>
> >> >>>
> >> >>> _______________________________________________
> >> >>> yt-dev mailing list
> >> >>> yt-dev at lists.spacepope.org <javascript:;>
> >> >>> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
> >> >>>
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> Cameron Hummels
> >> >> Postdoctoral Researcher
> >> >> Steward Observatory
> >> >> University of Arizona
> >> >> http://chummels.org
> >> >>
> >> >> _______________________________________________
> >> >> yt-dev mailing list
> >> >> yt-dev at lists.spacepope.org <javascript:;>
> >> >> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
> >> >>
> >> >
> >> >
> >> > _______________________________________________
> >> > yt-dev mailing list
> >> > yt-dev at lists.spacepope.org <javascript:;>
> >> > http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
> >> >
> >> _______________________________________________
> >> yt-dev mailing list
> >> yt-dev at lists.spacepope.org <javascript:;>
> >> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
> >
> >
> >
> > _______________________________________________
> > yt-dev mailing list
> > yt-dev at lists.spacepope.org <javascript:;>
> > http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
> >
> _______________________________________________
> yt-dev mailing list
> yt-dev at lists.spacepope.org <javascript:;>
> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.spacepope.org/pipermail/yt-dev-spacepope.org/attachments/20140619/6502bd8b/attachment.html>


More information about the yt-dev mailing list