[yt-dev] Answer test failures

Matthew Turk matthewturk at gmail.com
Tue May 28 05:18:14 PDT 2013


Hi Nathan,

Thanks for doing this!  I've accepted the answer test PR you issued.
I appreciate you taking care of this -- keeping the tests running in
the face of changes (improvements) to the solution can be a bit
thankless, so thank you!

-Matt

On Sun, May 26, 2013 at 10:54 PM, Nathan Goldbaum <nathan12343 at gmail.com> wrote:
> Sorry for the spam - the failures are real, I just forgot to pull and update
> before running the tests just now.
>
> On May 26, 2013, at 7:53 PM, Nathan Goldbaum <nathan12343 at gmail.com> wrote:
>
> Hmm, I may have spoken too soon, as I don't see failures when I run the
> answer tests on my laptop.
>
> Can anyone confirm the answer test failures reported on Piernik?
>
> -Nathan
>
> On May 26, 2013, at 7:51 PM, Nathan Goldbaum <nathan12343 at gmail.com> wrote:
>
> Hi all,
>
> It looks like redefinition of the TotalMass field has caused a couple of
> answer tests to change for the galaxy0030 dataset.  See the test reports on
> Piernik:
>
> http://piernik.astri.umk.pl:8080/job/py2.7-yt-2.x_testing/
> http://piernik.astri.umk.pl:8080/view/yt-2.x/job/py2.7-yt-2.x_answer.enzo.galaxy0030/
>
> I don't think this is particularly surprising given that the TotalMass field
> now properly includes star particles.  However, given the number of enzo/yt
> users out there, it might be worthwhile to make a somewhat bigger deal about
> this change.
>
> I'm happy to upload a new set of answer test results and issue a pull
> request for the update.  I'll try to get that done tonight.
>
> -Nathan
>
>
>
>
> _______________________________________________
> yt-dev mailing list
> yt-dev at lists.spacepope.org
> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
>



More information about the yt-dev mailing list