[yt-dev] Issue #582: HaloMassFunction uses Enzo ComovingBoxSize (yt_analysis/yt)

[Matthew Turk]

New issue 582: HaloMassFunction uses Enzo ComovingBoxSize
https://bitbucket.org/yt_analysis/yt/issue/582/halomassfunction-uses-enzo-comovingboxsize

Matthew Turk:

(reported by @mepa )

Inside `yt/analysis_modules/halo_mass_function/halo_mass_function.py` on line 215, there's a reference to `self.pf["ComovingBoxSize"]`.  I believe this is then converted into actual Mpc, not Mpc/h, and is then cubed to get the volume of the domain.

I am not entirely certain, but I believe this could be replaced either by:

`(self.pf.domain_width * self.pf["mpccm"]).prod()`

or:

`(self.pf.domain_width * self.pf["mpc"]).prod()`

depending on whether the mass function is supposed to be proper or comoving; the comments in the code suggest to me very strongly it's the first of the two, not the second.

@brittonsmith I am tagging you in the ticket, but if you aren't able to take a look at this feel free to re-assign to me.

Responsible: brittonsmith