[yt-dev] Unit testing PRs

Anthony Scopatz scopatz at gmail.com
Thu Oct 11 20:44:38 PDT 2012


On Thu, Oct 11, 2012 at 6:29 PM, Matthew Turk <matthewturk at gmail.com> wrote:

> Hi all,
>
> As I noted in the other thread, Stephen issued a PR for unit testing
> the kD-tree:
>
> https://bitbucket.org/yt_analysis/yt/pull-request/296/kd-trees-tests/diff
>
> I've just issued one for the profiles:
>
>
> https://bitbucket.org/yt_analysis/yt/pull-request/297/tests-for-profiles/diff
>
> I think that once these get reviewed and accepte,d they can be used as
> examples for how to move forward.  Mine also uses fake random data in
> a parameter file, which I think can be useful for testing other
> functionality as well.  Anthony, do these match up with what you were
> thinking of for testing?  (Feel free to comment in the PR itself.)
>

Yes, I think that these look good subject to my comments in the PRs
themselves.  I like what you did with the test generators in particular ;)

Be Well
Anthony


>
> -Matt
> _______________________________________________
> yt-dev mailing list
> yt-dev at lists.spacepope.org
> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.spacepope.org/pipermail/yt-dev-spacepope.org/attachments/20121011/cff398ce/attachment.html>


More information about the yt-dev mailing list