[yt-dev] [yt_analysis/yt] Adding OffAxisSlice (pull request #178)

[j s oishi]

Nathan,

Sorry, I may have been unclear. I definitely wanted the user to get a
PlotWindow (or PW-like) object back. Your approach is great.

j

On Saturday, June 23, 2012, Nathan Goldbaum wrote:

> Hi Jeff,
>
> Yeah, I wanted to expose some of the convenience functions in the
> PlotWindow class (e.g. zoom() and pan()) and also keep the save() method.
>  If the plots return matplotlib axes objects then the user would have to
> manually generate the filename string to pass to savefig().  I really like
> how yt appends the field name to the filename of images it produces.
>
> I'm open to returning an MPL axes object instead, but I'd like to find a
> way to keep the nice filename conventions we have in yt.
>
> -Nathan
>
> On Jun 23, 2012, at 4:51 PM, j s oishi wrote:
>
> > Hi guys,
> >
> > Things are looking great. I'm intrigued by making the plot commands
> functions returning PWViewerMPL objects. I'm guessing these are essentially
> end-user convenience functions, which is cool. How do you envision dealing
> with future backend swaps? Just rewriting the convenience function?
> >
> > Regardless, I think this is shaping up very well.
> >
> > j
> > On Saturday, June 23, 2012, Matthew Turk wrote:
> > Awesome work, Nathan!  I've looked these over and seen the example
> > images and they look good, but maybe Jeff could take a quick look at
> > how the PlotWindow is shaping up.
> >
> >
> > ---------- Forwarded message ----------
> > From: Nathan Goldbaum <pullrequests-noreply at bitbucket.org <javascript:;>
> >
> > Date: Sat, Jun 23, 2012 at 4:39 PM
> > Subject: [yt_analysis/yt] Adding OffAxisSlice (pull request #178)
> > To: matthewturk at gmail.com <javascript:;>
> >
> >
> > A new pull request has been opened by Nathan Goldbaum.
> >
> > ngoldbaum/yt-ngoldbaum has changes to be pulled into yt_analysis/yt.
> >
> >
> https://bitbucket.org/yt_analysis/yt/pull-request/178/adding-offaxisslice
> >
> > Title: Adding OffAxisSlice
> >
> > This finishes up the new plotting interface by adding OffAxisSlice.
> > I've also taken the opportunity to add a docstring for
> > get_rotation_matrix() in utilities/math_utils.py and to correct a bug
> > in ObliqueFixedResolutionBuffer that caused the buffer to be inverted.
> >
> > Changes to be pulled:
> >
> >
> >
> > --
> > This is an issue notification from bitbucket.org.
> > You are receiving this either because you are the participating
> > in a pull request, or you are following it.
> > _______________________________________________
> > yt-dev mailing list
> > yt-dev at lists.spacepope.org <javascript:;>
> > http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
> > !DSPAM:10175,4fe62c6215777636615206!
> _______________________________________________
> > yt-dev mailing list
> > yt-dev at lists.spacepope.org <javascript:;>
> > http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
> >
> >
> > !DSPAM:10175,4fe62c6215777636615206!
>
> _______________________________________________
> yt-dev mailing list
> yt-dev at lists.spacepope.org <javascript:;>
> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.spacepope.org/pipermail/yt-dev-spacepope.org/attachments/20120623/2371d954/attachment.html>