[Yt-dev] Volume rendering with current (3628:da3894bf42a5) change set

[j s oishi]

Hi Chris,

Sorry for the delay. I have pushed your changes to the main yt
repository. Thanks for your contribution. Once you get a sample
dataset to me (off list!), I can start to look in more detail at your
code. Having reviewed your changesets, I agree that we really need to
make a unified BoxLib frontend that Orion, MAESTRO, and CASTRO all
inherit from. I will see if I can also get my hands on a CASTRO
dataset too. I suspect we can make this happen fairly quickly, once I
can find some time to sit down and do it.

thanks again,

j

On Tue, Jan 4, 2011 at 2:10 PM, Chris Malone <chris.m.malone at gmail.com> wrote:
> Hi Matt,
>
>> Do you want to push your Maestro changes so that we can
>> take a look at them, see how they are implemented?
>>
>
> Please find attached my first run-through of adding Maestro support as an hg
> bundle.  There were only a few things I had to change from the Orion
> frontend because they both use the BoxLib data format.  I did have to make a
> change in the OrionStaticOutput._is_valid method to distinguish between the
> two formats.
>
> I often wondered if it would make more sense to split the frontends based on
> file format, and then let each code subclass from a particular frontend?
> For example, have an HDF5 frontend that Flash and Enzo can subclass.  I'm
> not sure it would make things any cleaner...
>
> Chris
>
> _______________________________________________
> Yt-dev mailing list
> Yt-dev at lists.spacepope.org
> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
>
>