[Yt-dev] Module renames

Matthew Turk matthewturk at gmail.com
Mon Jun 7 11:37:10 PDT 2010


I agree, yes -- when you rename a module, it's fine to fix all the
other imports that reference that module.

-Matt

On Mon, Jun 7, 2010 at 2:36 PM, Britton Smith <brittonsmith at gmail.com> wrote:
> Matt has pointed out to me that the HaloFinding that I referenced did not
> actually count, since that itself wasn't the Class.  I am actually changing
> my mind on this point anyway.  We should probably just be in charge of
> changing all import statements in all files when we do the file name
> changing.  That way we run a smaller risk of having broken imports for a
> period of time.
>
> Britton
>
> On Mon, Jun 7, 2010 at 8:26 PM, Stephen Skory <stephenskory at yahoo.com>
> wrote:
>>
>> Britton,
>>
>> >>Some of the files I've been assigned refer to things that Stephen will
>> >> probably change, such as HaloFinders -> halo_finders.  I will change things
>> >> like this according to this convention.  Maybe we should reply to this with
>> >> a list of files we changed, just to make sure we get all the imports right.
>>
>>
>> I'm fine with you changing things in stuff I've written to correspond to
>> changes you've just made. Is that what you did, anyway (I hope!)?
>>
>>  _______________________________________________________
>> sskory at physics.ucsd.edu           o__  Stephen Skory
>> http://physics.ucsd.edu/~sskory/ _.>/ _Graduate Student
>> ________________________________(_)_\(_)_______________
>> _______________________________________________
>> Yt-dev mailing list
>> Yt-dev at lists.spacepope.org
>> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
>
>
> _______________________________________________
> Yt-dev mailing list
> Yt-dev at lists.spacepope.org
> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
>
>



More information about the yt-dev mailing list