[Yt-dev] HaloFinding thoughts

[Stephen Skory]

Hi Britton & Matt,

> The HaloProfiler is wired to read in the HopAnalysis.out file in its current form.  The name isn't the most important thing, but I would still be in favor of leaving that alone and using new file names for new systems and functionality.

The way I see it is it's one fewer file that needs to be kept track of, and it's relevant information to add to each halo line. The way I have it now is it adds a column to the end of each line with the h5 file name if and only if .write_out is called by .write_particle_lists. At the top of the file, it now looks like:

# HALOS FOUND WITH (HOP/FOF). h5 FILENAME COLUMN: (True/False)

A file created by calling .write_out, like is done now, is unchanged from before except for the line above. Because the h5 filename is the last column, reading in the halo values using .split() means that HaloProfiler will work just fine with a file that has the h5 filenames anyway. The haloes file created by .write_particle_lists will have the same prefix name as the h5 files, making it easy to relate the files together.

I really think this is the more elegant solution. I can change it back and add a separate file if both of you still feel that that's the better solution. Of course I haven't comitted any of this, and I'm in no hurry to do so.

 _______________________________________________________
sskory at physics.ucsd.edu           o__  Stephen Skory
http://physics.ucsd.edu/~sskory/ _.>/ _Graduate Student
________________________________(_)_\(_)_______________