[Yt-dev] HDF5 HaloFinder preloading

[Stephen Skory]

> http://codereview.appspot.com/59041/diff/1/2#newcode197
> Line 197:
> Not sure we need this?

Yup. I commented it out and it was ok on a test run.

> I'd say
> something like
> 
> all_data = self.pf.h.all_data()
> all_data.quantities["TotalQuantity"]("ParticleMassMsun",
> lazy_reader=True)
> 
> which will automatically parallelize.  This would get rid of most of the
> following lines, and we could avoid the mpi_allsum, too.  I'll need to
> add in the preloading to the DQ object, however.

Let me know when you do this to DerivedQuantities, and I'll modify HaloFinding to reflect this idea above.

Awesome! Thanks!

 _______________________________________________________
sskory at physics.ucsd.edu           o__  Stephen Skory
http://physics.ucsd.edu/~sskory/ _.>/ _Graduate Student
________________________________(_)_\(_)_______________