[Yt-dev] Release 1.5
Matthew Turk
matthewturk at gmail.com
Wed Apr 22 21:57:45 PDT 2009
Awesome, looks great! So I guess if we go back to the list I suggested:
1. Join the yt/lagos/fof/FOF_Output.py and yt/lagos/hop/HOP_Output.py
files and put them as yt/lagos/HaloFinder.py
2. Remove as much code duplication as possible between the two by
refactoring into a base class and two subclasses
3. Add HOPHaloFinder and FOFHaloFinder classes
4. set HaloFinder = HOPHaloFinder at the bottom of yt/lagos/HaloFinder.py
5. Change all the recipes in examples/ and on the Wiki to use the new API
6. Fix yt/mods.py to import from the correct location
7. Email yt-users to notify about the change in API, but don't stress
the parallel nature just yet.
we've done 1, 2, 3. I think we can remove HopOutput.py,
SS_HopOutput.py, and FOF_Output.py and add HaloFinder.py in one go. I
can do this, which is 4 and 6, if you like and you can take care of 5
and 7.
Sound good?
-Matt
On Wed, Apr 22, 2009 at 9:15 PM, Stephen Skory <stephenskory at yahoo.com> wrote:
>
> Matt,
>
>> Can you check this and implement it in the new file?
>
> I ran some tests and it looks good, for both HOP and FoF. I think I've also fixed the maximum overdensity value, too. See:
>
>
> http://paste.enzotools.org/compare/108/107/
>
> The values between serial and parallel hop with this fix are the same to 1 part in 1,000,000.
>
> _______________________________________________________
> sskory at physics.ucsd.edu o__ Stephen Skory
> http://physics.ucsd.edu/~sskory/ _.>/ _Graduate Student
> ________________________________(_)_\(_)_______________
> _______________________________________________
> Yt-dev mailing list
> Yt-dev at lists.spacepope.org
> http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
>
More information about the yt-dev
mailing list